Skip to content

Commit 2638077

Browse files
committed
[more tests] testProcessForeignSchemaParallel & some clean up
1 parent 57839f8 commit 2638077

File tree

3 files changed

+40
-8
lines changed

3 files changed

+40
-8
lines changed

src/main/java/com/googlecode/scheme2ddl/UserObjectJobRunner.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,6 @@ int start(ConfigurableApplicationContext context, boolean launchedByDBA, String
6565
}
6666
}
6767

68-
private JobParameters getJobParameters(String schemaName, boolean launchedByDBA) {
69-
JobParametersBuilder parametersBuilder = new JobParametersBuilder();
70-
parametersBuilder.addString("schemaName", schemaName.toUpperCase());
71-
parametersBuilder.addString("launchedByDBA", Boolean.toString(launchedByDBA));
72-
return parametersBuilder.toJobParameters();
73-
}
74-
7568
private void writeJobExecutionStatus(JobExecution jobExecution, JobParameters jobParameters) {
7669
StepExecution step = jobExecution.getStepExecutions().toArray(new StepExecution[]{})[0];
7770
String schemaName = jobParameters.getString("schemaName");

src/test/java/com/googlecode/scheme2ddl/MainIT.java

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,31 @@ public void testProcessForeignSchema() throws Exception {
180180

181181
}
182182

183+
@Test
184+
public void testProcessForeignSchemaParallel() throws Exception {
185+
String outputPath = tempOutput.getAbsolutePath();
186+
187+
String[] args = {"-url", dbaUrl, "--schemas", "OUTLN", "--output", outputPath, "--parallel", "2"};
188+
189+
Main.main(args);
190+
String out = outContent.toString();
191+
192+
assertThat(out, containsString("Will try to process schema [OUTLN]"));
193+
assertThat(out, containsString("Found 8 items for processing in schema OUTLN"));
194+
195+
assertEqualsFileContent(outputPath + "/OUTLN/procedures/ora$grant_sys_select.sql",
196+
"CREATE OR REPLACE PROCEDURE \"OUTLN\".\"ORA$GRANT_SYS_SELECT\" as\n" +
197+
"begin\n" +
198+
" EXECUTE IMMEDIATE 'GRANT SELECT ON OUTLN.OL$ TO SELECT_CATALOG_ROLE';\n" +
199+
" EXECUTE IMMEDIATE 'GRANT SELECT ON OUTLN.OL$HINTS TO SELECT_CATALOG_ROLE';\n" +
200+
" EXECUTE IMMEDIATE 'GRANT SELECT ON OUTLN.OL$NODES TO SELECT_CATALOG_ROLE';\n" +
201+
" EXECUTE IMMEDIATE 'GRANT SELECT ON OUTLN.OL$ TO SYS WITH GRANT OPTION';\n" +
202+
" EXECUTE IMMEDIATE 'GRANT SELECT ON OUTLN.OL$HINTS TO SYS WITH GRANT OPTION';\n" +
203+
" EXECUTE IMMEDIATE 'GRANT SELECT ON OUTLN.OL$NODES TO SYS WITH GRANT OPTION';\n" +
204+
"end;\n" +
205+
"/");
206+
}
207+
183208
@Test
184209
public void testFilterAndReplaceSeqValue() throws Exception {
185210
String outputPath = tempOutput.getAbsolutePath();

src/test/java/com/googlecode/scheme2ddl/dao/UserObjectDaoImplIT.java

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,11 @@
33
import com.googlecode.scheme2ddl.ConfigurationIT;
44
import org.springframework.beans.factory.annotation.Autowired;
55
import org.springframework.boot.test.context.SpringBootTest;
6+
import org.springframework.jdbc.CannotGetJdbcConnectionException;
67
import org.springframework.jdbc.UncategorizedSQLException;
78
import org.springframework.jdbc.core.JdbcTemplate;
89
import org.springframework.test.context.testng.AbstractTestNGSpringContextTests;
10+
import org.testng.SkipException;
911
import org.testng.annotations.BeforeClass;
1012
import org.testng.annotations.BeforeMethod;
1113
import org.testng.annotations.Test;
@@ -27,9 +29,21 @@ public class UserObjectDaoImplIT extends AbstractTestNGSpringContextTests {
2729
@Autowired
2830
protected JdbcTemplate dbaJdbcTemplate;
2931

32+
@BeforeClass
33+
public void setUp() {
34+
try {
35+
dbaJdbcTemplate.execute("select 1 from dual");
36+
}
37+
catch (CannotGetJdbcConnectionException e){
38+
logger.warn("Ignore all test due", e);
39+
throw new SkipException("Ignore all test due " + e.getMessage());
40+
}
41+
42+
}
43+
3044

3145
@BeforeClass
32-
public void setUp() throws Exception {
46+
public void initDao() throws Exception {
3347
userObjectDao = new UserObjectDaoImpl();
3448

3549
userObjectDao.setLaunchedByDBA(false);

0 commit comments

Comments
 (0)