Skip to content

Commit 4058d2d

Browse files
authored
docs: enhance contributing document with releasing section (#19)
* docs: enhance contributing document with releasing section * fix: fix typo bath to patch
1 parent 26ede9e commit 4058d2d

File tree

3 files changed

+59
-4
lines changed

3 files changed

+59
-4
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ Please check if your PR fulfills the following requirements:
55
- [ ] The commit message follows our guidelines: CONTRIBUTING.md#commit
66
- [ ] Tests for the changes have been added (for bug fixes / features)
77
- [ ] Docs have been added / updated (for bug fixes / features)
8+
- [ ] The latest artifacts are committed (run `yarn build`)
89

910
## PR Type
1011

CONTRIBUTING.md

Lines changed: 58 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ yarn
1313
Build the typescript and package it for distribution
1414

1515
```bash
16-
yarn build && yarn package
16+
yarn build
1717
```
1818

1919
Run the tests :heavy_check_mark:
@@ -22,6 +22,62 @@ Run the tests :heavy_check_mark:
2222
yarn test
2323
```
2424

25+
Make sure you include the latest distribution built in your PR commits
26+
27+
```bash
28+
yarn build && git add .
29+
```
30+
31+
## Releasing a new version (for core contributors only)
32+
33+
Always release from main
34+
35+
```bash
36+
git fetch origin && git switch -C main origin/main
37+
```
38+
39+
Generate the changelog, commit and tag of the release.
40+
41+
```bash
42+
yarn release
43+
```
44+
45+
Push the generated commit into `origin/main`
46+
47+
```bash
48+
git push origin main
49+
```
50+
51+
Push the generated version tag into `origin/main`.
52+
53+
```bash
54+
git push --follow-tags origin main
55+
```
56+
57+
This Github action follows the [recommended release workflow](https://github.com/actions/toolkit/blob/master/docs/action-versioning.md#recommendations)
58+
59+
### Releasing minor and patch versions
60+
61+
> NOTE: This operation may need multiple attempts. Always verify that the sha of the latest major version tag matches the latest commit in the main branch
62+
63+
Match the major version release tag with the newly create release tag.
64+
65+
```bash
66+
git tag -fa v3 -m "update v3 tag to v3.x.y"
67+
```
68+
69+
Push the updated major version to force the release into the Github Marketplace
70+
71+
```bash
72+
git push origin v1 --force
73+
```
74+
75+
### Releasing a major version
76+
77+
Go to create a new release in Github a follow the instructions [there](https://github.com/ngworker/angular-versions-action/releases/new).
78+
79+
Use the major version format for the release. For example if the current major version tag is `v3` the new release version must be `v4`.
80+
2581
## <a name="rules"></a> Coding Rules
2682

2783
To ensure consistency throughout the source code, keep these rules in mind as you are working:
@@ -33,7 +89,7 @@ To ensure consistency throughout the source code, keep these rules in mind as yo
3389

3490
We have very precise rules over how our git commit messages can be formatted. This leads to **more
3591
readable messages** that are easy to follow when looking through the **project history**. But also,
36-
we use the git commit messages to **generate the Lumberjack changelog**.
92+
we use the git commit messages to **generate the angular-versions-action changelog**.
3793

3894
### Commit Message Format
3995

README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
# GitHub Action - Match Angular Versions
22

3-
> DISCLAIMER: THIS ACTION IS HIGHLY EXPERIMENTAL.
4-
53
This GitHub Action (written in JavaScript) modifies the root `package.json` of a project and replaces the version of all **Angular** related dependencies for given base version.
64

75
[![ngworker](https://img.shields.io/badge/ngworker-%40-red)](https://github.com/ngworker/)

0 commit comments

Comments
 (0)