Skip to content

Commit 886197a

Browse files
committed
fix: 🐛 modify only existing version, not override entire object
1 parent 792d0b7 commit 886197a

File tree

1 file changed

+13
-2
lines changed

1 file changed

+13
-2
lines changed

src/override-angular-versions.ts

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,19 @@ export function overrideAngularVersions(
66
path: string
77
): PackageJsonVersion {
88
const rawData = fs.readFileSync(path);
9-
let packageJson: PackageJsonVersion = JSON.parse(rawData.toString());
10-
packageJson = {...packageJson, ...angularVersions};
9+
const packageJson: PackageJsonVersion = JSON.parse(rawData.toString());
10+
11+
for (const prop in angularVersions.dependencies) {
12+
if (packageJson.dependencies.hasOwnProperty(prop)) {
13+
packageJson.dependencies[prop] = angularVersions.dependencies[prop];
14+
}
15+
}
16+
17+
for (const prop in angularVersions.devDependencies) {
18+
if (packageJson.devDependencies.hasOwnProperty(prop)) {
19+
packageJson.devDependencies[prop] = angularVersions.devDependencies[prop];
20+
}
21+
}
1122

1223
fs.writeFileSync(path, JSON.stringify(packageJson));
1324

0 commit comments

Comments
 (0)