Skip to content

Commit 5aeca7f

Browse files
authored
test: use standalone components where possible (#288)
# Tests - Convert components in non-classic Angular tests to standalone components
1 parent 95c0468 commit 5aeca7f

File tree

4 files changed

+19
-15
lines changed

4 files changed

+19
-15
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
steps:
3333
- name: Check out source code
3434
uses: actions/checkout@v3
35-
- name: Set up Node.js and install dependencies
35+
- name: Set up Node.js and Yarn
3636
uses: ./.github/actions/setup-node
3737
- name: Install package dependencies
3838
run: yarn install --frozen-lockfile --no-interactive
@@ -46,7 +46,7 @@ jobs:
4646
steps:
4747
- name: Check out source code
4848
uses: actions/checkout@v3
49-
- name: Set up Node.js and install dependencies
49+
- name: Set up Node.js and Yarn
5050
uses: ./.github/actions/setup-node
5151
- name: Install package dependencies
5252
run: yarn install --frozen-lockfile --no-interactive
@@ -61,7 +61,7 @@ jobs:
6161
steps:
6262
- name: Check out source code
6363
uses: actions/checkout@v3
64-
- name: Set up Node.js and install dependencies
64+
- name: Set up Node.js and Yarn
6565
uses: ./.github/actions/setup-node
6666
- name: Install package dependencies
6767
run: yarn install --frozen-lockfile --no-interactive

packages/router-component-store/src/lib/global-router-store/global-router-store-selectors.spec.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,21 @@
11
import { Component } from '@angular/core';
22
import { TestBed } from '@angular/core/testing';
3-
import { Router, Routes } from '@angular/router';
3+
import { Router, RouterOutlet, Routes } from '@angular/router';
44
import { RouterTestingModule } from '@angular/router/testing';
55
import { firstValueFrom } from 'rxjs';
66
import { RouterStore } from '../router-store';
77
import { GlobalRouterStore } from './global-router-store';
88
import { provideGlobalRouterStore } from './provide-global-router-store';
99

1010
@Component({
11+
standalone: true,
12+
imports: [RouterOutlet],
1113
template: '<router-outlet></router-outlet>',
1214
})
1315
class DummyAppComponent {}
1416

1517
@Component({
18+
standalone: true,
1619
template: '',
1720
})
1821
class DummyLoginComponent {}
@@ -33,7 +36,6 @@ describe(`${GlobalRouterStore.name} selectors`, () => {
3336
];
3437

3538
TestBed.configureTestingModule({
36-
declarations: [DummyAppComponent, DummyLoginComponent],
3739
imports: [RouterTestingModule.withRoutes(routes)],
3840
providers: [provideGlobalRouterStore()],
3941
});

packages/router-component-store/src/lib/local-router-store/local-router-store-selectors.spec.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,24 @@
11
import { Component, inject } from '@angular/core';
22
import { ComponentFixture, TestBed } from '@angular/core/testing';
33
import { By } from '@angular/platform-browser';
4-
import { Router, Routes } from '@angular/router';
4+
import { Router, RouterOutlet, Routes } from '@angular/router';
55
import { RouterTestingModule } from '@angular/router/testing';
66
import { firstValueFrom } from 'rxjs';
77
import { RouterStore } from '../router-store';
88
import { LocalRouterStore } from './local-router-store';
99
import { provideLocalRouterStore } from './provide-local-router-store';
1010

1111
@Component({
12+
standalone: true,
13+
imports: [RouterOutlet],
1214
template: '<router-outlet></router-outlet>',
1315
})
1416
class DummyAppComponent {}
1517

1618
@Component({
17-
template: '',
19+
standalone: true,
1820
viewProviders: [provideLocalRouterStore()],
21+
template: '',
1922
})
2023
class DummyLoginComponent {
2124
routerStore = inject(RouterStore);
@@ -43,7 +46,6 @@ describe(`${LocalRouterStore.name} selectors`, () => {
4346
];
4447

4548
TestBed.configureTestingModule({
46-
declarations: [DummyAppComponent, DummyLoginComponent],
4749
imports: [RouterTestingModule.withRoutes(routes)],
4850
});
4951

packages/router-component-store/src/lib/standalone-routed-component-test.spec.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import { CommonModule } from '@angular/common';
1+
import { AsyncPipe } from '@angular/common';
22
import { Component, inject } from '@angular/core';
33
import { ComponentFixtureAutoDetect, TestBed } from '@angular/core/testing';
44
import { By } from '@angular/platform-browser';
5-
import { Router, RouterModule } from '@angular/router';
5+
import { Router, RouterOutlet } from '@angular/router';
66
import { RouterTestingModule } from '@angular/router/testing';
77
import { Observable } from 'rxjs';
88
import { provideGlobalRouterStore } from './global-router-store/provide-global-router-store';
@@ -78,9 +78,9 @@ async function setup({
7878
}
7979

8080
@Component({
81-
imports: [CommonModule],
82-
selector: 'ngw-standalone-routed',
8381
standalone: true,
82+
selector: 'ngw-standalone-routed',
83+
imports: [AsyncPipe],
8484
template: `
8585
<p id="id-parameter">{{ id$ | async }}</p>
8686
<p id="url">{{ url$ | async }}</p>
@@ -95,16 +95,16 @@ class StandaloneRoutedComponent {
9595
}
9696

9797
@Component({
98-
selector: 'ngw-standalone-default',
9998
standalone: true,
99+
selector: 'ngw-standalone-default',
100100
template: `<h1>Default route</h1>`,
101101
})
102102
class StandaloneDefaultComponent {}
103103

104104
@Component({
105-
imports: [RouterModule],
106-
selector: 'ngw-standalone-app',
107105
standalone: true,
106+
selector: 'ngw-standalone-app',
107+
imports: [RouterOutlet],
108108
template: `<router-outlet></router-outlet>`,
109109
})
110110
class StandaloneAppComponent {}

0 commit comments

Comments
 (0)