Skip to content

Commit 1c0152e

Browse files
Merge pull request #85 from varit05/master
Minor improvement & updated readme file
2 parents 3abcffe + 07b0516 commit 1c0152e

File tree

3 files changed

+8
-13
lines changed

3 files changed

+8
-13
lines changed

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
- Angular project created via [Angular CLI](https://github.com/angular/angular-cli) v8.3.0 or greater.
99

1010
### Steps:
11-
1. run ```ng add @netlify-builder/deploy``` to add necessary dependencies. Once, it get installed,you will be prompted to enter (a) Site Id and (b) netlfy Token
11+
1. run ```ng add @netlify-builder/deploy``` to add necessary dependencies. Once, it get installed,you will be prompted to enter (a) Site Id and (b) Netlify Token
1212
![Screenshot](screenshots/step-1.png)
1313
2. run ```ng deploy``` assuming that you have [Angular CLI](https://github.com/angular/angular-cli) installed globally
1414

@@ -24,7 +24,6 @@
2424

2525
# Netlify Builder demo
2626

27-
2827
This repository contains an example of the Angular CLI Architect API.
2928

3029
## Builder

src/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ Deploy your Angular app to Netlify directly from the Angular CLI! 🚀
88

99
You will need two things in order to get started
1010

11-
- API ID (Site ID) : Every netlify app have a API ID which uniquly identify that app. You can find this inside your project's Setting/General section.
11+
- API ID (Site ID) : Every Netlify application has an API ID that uniquely identify the respective app. You can find it inside your project's Setting/General section.
1212
![alt text](https://raw.githubusercontent.com/ngx-builders/netlify-builder/master/screenshots/api-id.png)
13-
- [Personal access tokens](https://app.netlify.com/user/applications#personal-access-tokens) : Acess token give you the ability to communicate with netlify over API. This will help you in pushing the code on Netlify.
13+
- [Personal access tokens](https://app.netlify.com/user/applications#personal-access-tokens) : Access token gives the ability to communicate with Netlify over API and helps to push the code on Netlify.
1414
![alt text](https://raw.githubusercontent.com/ngx-builders/netlify-builder/master/screenshots/personal-access-token.png)
1515

1616
## Setting up this Builder
@@ -19,11 +19,11 @@ You will need two things in order to get started
1919
ng add @netlify-builder/deploy
2020
```
2121

22-
This command will configure everything, you just need to provide API ID and Personal access tokens when it will ask you for that.
22+
The above command will configure everything, you just need to provide API ID and Personal access tokens when it will ask you for that.
2323

2424
## That's it. Now, you are good to go
2525

26-
Now whenever you want to deploy your angular project just run a command `ng run [YOUR_PROJECT_NAME]:deploy` and your project got live with new update.
26+
Now, Whenever you want to deploy your angular project just run a command `ng run [YOUR_PROJECT_NAME]:deploy` and your project will be deployed with new updates.
2727

2828

2929
## 📦 Options <a name="options"></a>
@@ -57,7 +57,7 @@ This command causes the `--configuration` setting to have no effect.
5757
- **optional**
5858
- Default: `false` (string)
5959
- Example:
60-
- `ng deploy --create`Will create a new site if there is no site id or the site id is does not exists on netlify
60+
- `ng deploy --create`The command will create a new site if there is no site id or the site id does not exists on netlify
6161

6262
#### --base-href <a name="base-href"></a>
6363

src/ng-add/index.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,9 @@ function addPackageJsonDependencies(): Rule {
2222
function getWorkspace(host: Tree): { path: string; workspace: experimental.workspace.WorkspaceSchema } {
2323
const possibleFiles = ['/angular.json', './angular.json'];
2424
const path = possibleFiles.find(path => host.exists(path));
25-
26-
if (!path) {
27-
throw new SchematicsException(`Could not find angular.json`);
28-
}
29-
3025
const configBuffer = host.read(path);
31-
if (!configBuffer) {
26+
27+
if (!path || !configBuffer) {
3228
throw new SchematicsException(`Could not find angular.json`);
3329
}
3430

0 commit comments

Comments
 (0)