Skip to content

Commit 88b2ffa

Browse files
Merge pull request #130 from patelvimal/master
Removed "addPackageJsonDependencies" as it is not required as we have "ng-add" in package.json file
2 parents f484595 + 51a6a84 commit 88b2ffa

File tree

3 files changed

+4
-23
lines changed

3 files changed

+4
-23
lines changed

src/ng-add/index.ts

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,7 @@
11
import { Rule, SchematicContext, SchematicsException, Tree, chain } from '@angular-devkit/schematics';
22
import { JsonParseMode, parseJson } from '@angular-devkit/core';
3-
import { addPackageJsonDependency, NodeDependency, NodeDependencyType } from 'schematics-utilities';
43
import { Workspace } from '../interfaces';
54

6-
function addPackageJsonDependencies(): Rule {
7-
return (host: Tree, context: SchematicContext) => {
8-
9-
// always add the package under dev dependencies
10-
const dependencies: NodeDependency[] = [
11-
{ type: NodeDependencyType.Dev, version: '~3.1.0', name: '@netlify-builder/deploy' }
12-
];
13-
14-
dependencies.forEach(dependency => {
15-
addPackageJsonDependency(host, dependency);
16-
context.logger.log('info', `✅️ Added "${dependency.name}" into ${dependency.type}`);
17-
});
18-
19-
return host;
20-
};
21-
}
22-
235
function getWorkspace(host: Tree): { path: string; workspace: Workspace } {
246
const possibleFiles = ['/angular.json', './angular.json'];
257
const path = possibleFiles.find(path => host.exists(path));
@@ -108,6 +90,5 @@ export function netlifyBuilder(options: NgAddOptions): Rule {
10890
export default function (options: NgAddOptions): Rule {
10991
return chain([
11092
netlifyBuilder(options),
111-
addPackageJsonDependencies()
11293
]);
113-
}
94+
}

src/ng-add/schema.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"$schema": "http://json-schema.org/schema",
3-
"id": "netlify-builder-deploy-ng-add",
3+
"$id": "netlify-builder-deploy-ng-add",
44
"title": "Netlify Builder ng-add schematic",
55
"type": "object",
66
"properties": {

src/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@netlify-builder/deploy",
3-
"version": "4.0.0",
3+
"version": "4.1.0",
44
"description": "A Netlify builder schematics for deployment",
55
"main": "index.js",
66
"builders": "./builders.json",
@@ -49,7 +49,7 @@
4949
"dependencies": {
5050
"@angular-devkit/architect": "^0.1200.0",
5151
"@angular-devkit/core": "^12.0.0",
52-
"schematics-utilities": "^2.0.2",
52+
"@angular-devkit/schematics": "^12.0.0",
5353
"netlify": "^6.1.1"
5454
}
5555
}

0 commit comments

Comments
 (0)