Skip to content

Commit 1219a7f

Browse files
Merge pull request #24 from ngx-builders/fix--remove-package-from-ng-add
Fix-remove package from ng add
2 parents 017abf3 + 3d43d49 commit 1219a7f

File tree

2 files changed

+6
-35
lines changed

2 files changed

+6
-35
lines changed

ng-add/index.ts

Lines changed: 2 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,5 @@
1-
import { Rule, SchematicContext, SchematicsException, Tree, chain } from '@angular-devkit/schematics';
1+
import { Rule, SchematicContext, SchematicsException, Tree } from '@angular-devkit/schematics';
22
import { experimental, JsonParseMode, parseJson } from '@angular-devkit/core';
3-
import { addPackageJsonDependency, NodeDependency, NodeDependencyType } from 'schematics-utilities';
4-
import { NodePackageInstallTask } from '@angular-devkit/schematics/tasks';
5-
6-
function addPackageJsonDependencies(): Rule {
7-
return (host: Tree, context: SchematicContext) => {
8-
9-
// always add the package under dev dependencies
10-
const dependencies: NodeDependency[] = [
11-
{ type: NodeDependencyType.Dev, version: '~0.0.0', name: '@ngx-builders/analyze' }
12-
];
13-
14-
dependencies.forEach(dependency => {
15-
addPackageJsonDependency(host, dependency);
16-
context.logger.log('info', `✅️ Added "${dependency.name}" into ${dependency.type}`);
17-
});
18-
19-
return host;
20-
};
21-
}
223

234
function getWorkspace(host: Tree): { path: string; workspace: experimental.workspace.WorkspaceSchema } {
245
const possibleFiles = ['/angular.json', './angular.json'];
@@ -107,19 +88,6 @@ export function sourceMapBuilder(options: NgAddOptions): Rule {
10788
};
10889
}
10990

110-
export function installPackageJsonDependencies(): Rule {
111-
return (host: Tree, context: SchematicContext) => {
112-
context.addTask(new NodePackageInstallTask());
113-
context.logger.log('info', `🔍 Installing packages...`);
114-
115-
return host;
116-
};
117-
}
118-
11991
export default function (options: NgAddOptions): Rule {
120-
return chain([
121-
sourceMapBuilder(options),
122-
addPackageJsonDependencies(),
123-
installPackageJsonDependencies()
124-
]);
92+
return sourceMapBuilder(options)
12593
}

package.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
{
22
"name": "@ngx-builders/analyze",
3-
"version": "0.0.6",
3+
"version": "0.0.8",
44
"description": "",
55
"main": "index.js",
66
"builders": "./builders.json",
77
"schematics": "./collection.json",
8+
"ng-add": {
9+
"save": "devDependencies"
10+
},
811
"scripts": {
912
"build": "tsc",
1013
"test": "ts-node node_modules/jasmine/bin/jasmine command/index_spec.ts"

0 commit comments

Comments
 (0)