Merge pull request #1580 from ngx-translate/feat/instant/undefined-value

feat(service/instant, get): accept empty string

Author: CodeAndWeb

projects/ngx-translate/src/lib/translate.service.ts

@@ -511,7 +511,7 @@ export class TranslateService implements ITranslateService {
         interpolateParams?: InterpolationParameters,
     ): Observable<Translation> {
         if (!isDefinedAndNotNull(key) || !key.length) {
-            throw new Error(`Parameter "key" is required and cannot be empty`);
+            return of("");
         }
         // check if we are loading a new translation to use
         if (this.pending) {
@@ -583,7 +583,7 @@ export class TranslateService implements ITranslateService {
         interpolateParams?: InterpolationParameters,
     ): Translation {
         if (!isDefinedAndNotNull(key) || key.length === 0) {
-            throw new Error('Parameter "key" is required and cannot be empty');
+            return "";
         }
 
         const result = this.getParsedResult(key, interpolateParams);

projects/ngx-translate/src/tests/translate.service.spec.ts

@@ -227,22 +227,17 @@ describe("TranslateService", () => {
         });
     });
 
-    it("should throw if you forget the key", () => {
+    it("Should ignore if you forget the key", () => {
         translate.use("en");
 
-        expect(() => {
-            const key: Record<string, string> = {};
-            translate.get(key["x"]);
-        }).toThrowError('Parameter "key" is required and cannot be empty');
-
-        expect(() => {
-            translate.get("");
-        }).toThrowError('Parameter "key" is required and cannot be empty');
+        const key: Record<string, string> = {};
+        translate.get(key["x"]).subscribe((res: Translation) => {
+            expect(res).toEqual("");
+        });
 
-        expect(() => {
-            const key: Record<string, string> = {};
-            translate.instant(key["x"]);
-        }).toThrowError('Parameter "key" is required and cannot be empty');
+        translate.get("").subscribe((res: Translation) => {
+            expect(res).toEqual("");
+        });
     });
 
     it("should be able to get translations with nested keys", () => {
@@ -1066,24 +1061,20 @@ describe("TranslateService (Error Conditions and Recovery)", () => {
 
     describe("Invalid Parameter Handling", () => {
         it("should handle null parameters gracefully", () => {
-            expect(() => {
-                // eslint-disable-next-line @typescript-eslint/no-explicit-any
-                translate.get(null as any);
-            }).toThrowError('Parameter "key" is required and cannot be empty');
-        });
+            // eslint-disable-next-line @typescript-eslint/no-explicit-any
+            translate.get(null as any).subscribe((res: Translation) => {
+                expect(res).toEqual("");
+            });
 
-        it("should handle undefined parameters gracefully", () => {
-            expect(() => {
-                // eslint-disable-next-line @typescript-eslint/no-explicit-any
-                translate.get(undefined as any);
-            }).toThrowError('Parameter "key" is required and cannot be empty');
-        });
+            // eslint-disable-next-line @typescript-eslint/no-explicit-any
+            translate.get(undefined as any).subscribe((res: Translation) => {
+                expect(res).toEqual("");
+            });
 
-        it("should handle non-string parameters gracefully", () => {
-            expect(() => {
-                // eslint-disable-next-line @typescript-eslint/no-explicit-any
-                translate.get(123 as any);
-            }).toThrowError('Parameter "key" is required and cannot be empty');
+            // eslint-disable-next-line @typescript-eslint/no-explicit-any
+            translate.get(123 as any).subscribe((res: Translation) => {
+                expect(res).toEqual("");
+            });
         });
 
         it("should handle array with invalid elements", () => {