fix(http-loader): correct spelling of 'resources' and update deprecated properties

Author: rbalet

projects/http-loader/src/lib/http-loader.ts

@@ -10,10 +10,16 @@ export interface TranslateHttpLoaderResource {
 }
 
 export interface TranslateHttpLoaderConfig {
-    prefix: string;
-    suffix: string;
+    /**
+     * @deprecated Use `resources` instead. `prefix` and `suffix` will be removed in a future version.
+     */
+    prefix?: string;
+    /**
+     * @deprecated Use `resources` instead. `prefix` and `suffix` will be removed in a future version.
+     */
+    suffix?: string;
     showLog?: boolean;
-    ressources: (string | TranslateHttpLoaderResource)[];
+    resources: (string | TranslateHttpLoaderResource)[];
     enforceLoading: boolean;
     useHttpBackend: boolean;
 }
@@ -31,7 +37,7 @@ export class TranslateHttpLoader implements TranslateLoader {
         this.config = {
             prefix: "/assets/i18n/",
             suffix: ".json",
-            ressources: [],
+            resources: [],
             enforceLoading: false,
             useHttpBackend: false,
             ...inject(TRANSLATE_HTTP_LOADER_CONFIG),
@@ -48,43 +54,28 @@ export class TranslateHttpLoader implements TranslateLoader {
     public getTranslation(lang: string): Observable<TranslationObject> {
         const cacheBuster = this.config.enforceLoading ? `?enforceLoading=${Date.now()}` : "";
 
-        if (this.config.ressources.length > 0) {
-            const requests = this.config.ressources.map((resource) => {
-                let path: string;
+        if ((!this.config.resources || this.config.resources.length <= 0) && this.config.prefix)
+            this.config.resources = [{ prefix: this.config.prefix, suffix: this.config.suffix }];
 
-                if (typeof resource === "string") path = `${resource}${lang}.json`;
-                else path = `${resource.prefix}${lang}${resource.suffix ?? ".json"}`;
+        const requests = this.config.resources.map((resource) => {
+            let path: string;
 
-                return this.http.get<TranslationObject>(`${path}${cacheBuster}`).pipe(
-                    catchError((err) => {
-                        if (
-                            this.config.showLog ||
-                            (resource as TranslateHttpLoaderResource).showLog
-                        ) {
-                            console.error(`Error loading translation for ${lang}:`, err);
-                        }
-                        return of({});
-                    }),
-                );
-            });
+            if (typeof resource === "string") path = `${resource}${lang}.json`;
+            else path = `${resource.prefix}${lang}${resource.suffix ?? ".json"}`;
 
-            return forkJoin(requests).pipe(
-                map((response) => response.reduce((acc, curr) => mergeDeep(acc, curr), {})),
-            ) as Observable<TranslationObject>;
-        }
-
-        return this.http
-            .get<TranslationObject>(
-                `${this.config.prefix}${lang}${this.config.suffix}${cacheBuster}`,
-            )
-            .pipe(
+            return this.http.get<TranslationObject>(`${path}${cacheBuster}`).pipe(
                 catchError((err) => {
-                    if (this.config.showLog) {
+                    if (this.config.showLog || (resource as TranslateHttpLoaderResource).showLog) {
                         console.error(`Error loading translation for ${lang}:`, err);
                     }
                     return of({});
                 }),
             );
+        });
+
+        return forkJoin(requests).pipe(
+            map((response) => response.reduce((acc, curr) => mergeDeep(acc, curr), {})),
+        ) as Observable<TranslationObject>;
     }
 }
 

projects/test-app/src/app/app.config.ts

@@ -12,10 +12,8 @@ export const appConfig: ApplicationConfig = {
         provideHttpClient(),
         provideTranslateService({
             loader: provideTranslateHttpLoader({
-                prefix: "./i18n/",
-                suffix: ".json",
                 enforceLoading: true,
-                ressources: [{ prefix: "./i18n/another/", suffix: ".json" }, { prefix: "./i18n/" }],
+                resources: [{ prefix: "./i18n/another/", suffix: ".json" }, { prefix: "./i18n/" }],
             }),
         }),
     ],