clarification

Author: ngxson

CMakeLists.txt

@@ -168,8 +168,7 @@ add_subdirectory(src)
 # utils, programs, examples and tests
 #
 
-if (NOT LLAMA_BUILD_EXAMPLES)
-    # curl is only needed for examples
+if (NOT LLAMA_BUILD_EXAMPLES OR NOT LLAMA_BUILD_COMMON)
     set(LLAMA_CURL OFF)
 endif()
 

common/CMakeLists.txt

@@ -85,7 +85,10 @@ set(LLAMA_COMMON_EXTRA_LIBS build_info)
 
 # Use curl to download model url
 if (LLAMA_CURL)
-    find_package(CURL REQUIRED)
+    find_package(CURL)
+    if (NOT CURL_FOUND)
+        message(FATAL_ERROR "Could NOT find CURL. Hint: to disable this feature, set -DLLAMA_CURL=OFF")
+    endif()
     target_compile_definitions(${TARGET} PUBLIC LLAMA_USE_CURL)
     include_directories(${CURL_INCLUDE_DIRS})
     find_library(CURL_LIBRARY curl REQUIRED)

tests/CMakeLists.txt

@@ -133,7 +133,7 @@ endif()
 llama_target_and_test(test-log.cpp)
 llama_target_and_test(test-chat-template.cpp)
 
-# this fails on windows (github hosted runner) due to missing .NET, so we disable it
+# this fails on windows (github hosted runner) due to curl DLL not found (exit code 0xc0000135)
 if (NOT WIN32)
     llama_target_and_test(test-arg-parser.cpp)
 endif()