feat(connect): allow to pass date object (#647)

Author: kanidjar

libs/ngxtension/connect/src/connect.spec.ts

@@ -105,6 +105,17 @@ describe(connect.name, () => {
 				expect(state()).toEqual(5);
 			});
 		});
+
+		it('should allow connecting a date object', () => {
+			const state = signal(new Date('December 17, 1995 03:24:00'));
+
+			TestBed.runInInjectionContext(() => {
+				const sourceSignalOne = signal(new Date());
+				connect(state).with(() => sourceSignalOne());
+				TestBed.flushEffects();
+				expect(state()).toEqual(sourceSignalOne());
+			});
+		});
 	});
 
 	describe('connects an observable to a signal in injection context', () => {
@@ -164,6 +175,11 @@ describe(connect.name, () => {
 			component.objectSource$.next(1);
 			expect(component.objectSignal()).toEqual(1);
 
+			const date = new Date('December 17, 1995 03:24:00');
+			component.objectSource$.next({});
+			component.objectSource$.next(date);
+			expect(component.objectSignal()).toEqual(date);
+
 			component.objectSource$.next({});
 			component.objectSource$.next(undefined);
 			expect(component.objectSignal()).toEqual(undefined);

libs/ngxtension/connect/src/connect.ts

@@ -125,12 +125,19 @@ export function connect(signal: WritableSignal<unknown>, ...args: any[]) {
 
 					if (!isObject(x)) {
 						const reducedValue = reducer ? reducer(prev, x) : x;
+
 						return isObject(reducedValue)
 							? { ...prev, ...(reducedValue as object) }
 							: reducedValue;
 					}
 
-					return { ...prev, ...((reducer?.(prev, x) || x) as object) };
+					const curr = reducer?.(prev, x) || x;
+
+					if (isDate(curr)) {
+						return new Date(curr);
+					}
+
+					return { ...prev, ...(curr as object) };
 				});
 			};
 
@@ -151,11 +158,17 @@ export function connect(signal: WritableSignal<unknown>, ...args: any[]) {
 		return effect(
 			() => {
 				signal.update((prev) => {
+					const curr = originSignal();
+
 					if (!isObject(prev)) {
-						return originSignal();
+						return curr;
 					}
 
-					return { ...prev, ...(originSignal() as object) };
+					if (isDate(curr)) {
+						return new Date(curr);
+					}
+
+					return { ...prev, ...(curr as object) };
 				});
 			},
 			{ injector },
@@ -270,6 +283,10 @@ function parseArgs(
 	return [null, null, args[0] as Injector | DestroyRef, false, null];
 }
 
+function isDate(val: any): val is Date {
+	return val instanceof Date;
+}
+
 function isObject(val: any): val is object {
 	return (
 		typeof val === 'object' &&