Skip to content

Commit 2cec1db

Browse files
committed
Updated the IRedisSerializer methods to be easier replaced with CacheSerializeBase
1 parent f8975b4 commit 2cec1db

File tree

4 files changed

+7
-11
lines changed

4 files changed

+7
-11
lines changed

StackExRedis/NHibernate.Caches.StackExRedis/AbstractRegionStrategy.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ public virtual void Put(object key, object value)
251251
throw new ArgumentNullException(nameof(value));
252252
}
253253
var cacheKey = GetCacheKey(key);
254-
var serializedValue = Serializer.Serialize(value);
254+
RedisValue serializedValue = Serializer.Serialize(value);
255255

256256
if (string.IsNullOrEmpty(PutScript))
257257
{

StackExRedis/NHibernate.Caches.StackExRedis/Async/AbstractRegionStrategy.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ public virtual Task PutAsync(object key, object value, CancellationToken cancell
129129
async Task InternalPutAsync()
130130
{
131131
var cacheKey = GetCacheKey(key);
132-
var serializedValue = Serializer.Serialize(value);
132+
RedisValue serializedValue = Serializer.Serialize(value);
133133

134134
if (string.IsNullOrEmpty(PutScript))
135135
{

StackExRedis/NHibernate.Caches.StackExRedis/BinaryRedisSerializer.cs

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ namespace NHibernate.Caches.StackExRedis
1010
public class BinaryRedisSerializer : IRedisSerializer
1111
{
1212
/// <inheritdoc />
13-
public RedisValue Serialize(object value)
13+
public byte[] Serialize(object value)
1414
{
1515
var serializer = new BinaryFormatter();
1616
using (var stream = new MemoryStream())
@@ -21,13 +21,8 @@ public RedisValue Serialize(object value)
2121
}
2222

2323
/// <inheritdoc />
24-
public object Deserialize(RedisValue value)
24+
public object Deserialize(byte[] value)
2525
{
26-
if (value.IsNull)
27-
{
28-
return null;
29-
}
30-
3126
var serializer = new BinaryFormatter();
3227
using (var stream = new MemoryStream(value))
3328
{

StackExRedis/NHibernate.Caches.StackExRedis/IRedisSerializer.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,20 +5,21 @@ namespace NHibernate.Caches.StackExRedis
55
/// <summary>
66
/// Defines methods for serializing and deserializing objects that will be stored/retrieved for Redis.
77
/// </summary>
8+
// TODO: Remove and use CacheSerializeBase
89
public interface IRedisSerializer
910
{
1011
/// <summary>
1112
/// Serialize the object to a <see cref="RedisValue"/> to be stored into Redis.
1213
/// </summary>
1314
/// <param name="value">The object to serialize.</param>
1415
/// <returns>A serialized <see cref="RedisValue"/> that can be stored into Redis.</returns>
15-
RedisValue Serialize(object value);
16+
byte[] Serialize(object value);
1617

1718
/// <summary>
1819
/// Deserialize the <see cref="RedisValue"/> that was retrieved from Redis.
1920
/// </summary>
2021
/// <param name="value">The value to deserialize.</param>
2122
/// <returns>The object that was serialized.</returns>
22-
object Deserialize(RedisValue value);
23+
object Deserialize(byte[] value);
2324
}
2425
}

0 commit comments

Comments
 (0)