Merge pull request #154 from pcrockett/master

Removed a ton of build warnings

Author: jagregory

src/FluentNHibernate.Specs/Conventions/BiDirectionalKeysSpecs.cs

@@ -21,14 +21,11 @@ public class when_mapping_a_many_to_one_one_to_many_bi_directional_relationship
             child = mappings.SelectMany(x => x.Classes).FirstOrDefault(x => x.Type == typeof(Child));
         };
 
-        // these are ignored due to a regression this code caused - as this feature was added only as an
-        // experiment, I doubt anyone will miss it for the time being.
-
-        [Ignore]
+        [Ignore("Ignored due to a regression this code caused - as this feature was added only as an experiment, I doubt anyone will miss it for the time being.")]
         It should_use_the_many_to_one_columns_for_the_one_to_many_key = () =>
             parent.Collections.Single().Key.Columns.Select(x => x.Name).ShouldContainOnly("one", "two");
 
-        [Ignore]
+        [Ignore("Ignored due to a regression this code caused - as this feature was added only as an experiment, I doubt anyone will miss it for the time being.")]
         It shouldnt_alter_the_many_to_one_columns = () =>
             child.References.Single().Columns.Select(x => x.Name).ShouldContainOnly("one", "two");
 

src/FluentNHibernate.Specs/FluentNHibernate.Specs.csproj

@@ -42,6 +42,7 @@
     <WarningLevel>4</WarningLevel>
     <PlatformTarget>x86</PlatformTarget>
     <CodeAnalysisRuleSet>AllRules.ruleset</CodeAnalysisRuleSet>
+    <NoWarn>169,649</NoWarn>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <DebugType>pdbonly</DebugType>

src/FluentNHibernate.Testing/FluentNHibernate.Testing.csproj

@@ -42,7 +42,7 @@
     <PlatformTarget>x86</PlatformTarget>
     <ErrorReport>prompt</ErrorReport>
     <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
-    <NoWarn>169</NoWarn>
+    <NoWarn>169,1591</NoWarn>
     <CodeAnalysisRuleSet>AllRules.ruleset</CodeAnalysisRuleSet>
     <DocumentationFile>bin\Debug\FluentNHibernate.Testing.xml</DocumentationFile>
   </PropertyGroup>