Removed unneeded abstract class and fixed naming of variables

Author: Ignition

src/FluentNHibernate.Testing/Visitors/RelationshipPairingVisitorSpec.cs

@@ -7,54 +7,51 @@
 
 namespace FluentNHibernate.Testing.Visitors
 {
-    public abstract class RelationshipPairingVisitorSpec : Specification
+    [TestFixture]
+    public class when_the_relationship_pairing_visitor_visits_with_multiple_many_to_one_mapping_references : Specification
     {
         protected RelationshipPairingVisitor visitor;
-        protected CollectionMapping collectionMappingToZ;
-        protected ManyToOneMapping manyToOneZToHolder;
-        protected ManyToOneMapping manyToOneYToHolder;
-    }
+        protected CollectionMapping collectionMappingToBRankedSecond;
+        protected ManyToOneMapping manyToOneBRankedSecondToHolder;
+        protected ManyToOneMapping manyToOneARankedFirstToHolder;
 
-    [TestFixture]
-    public class when_the_relationship_pairing_visitor_visits_with_multiple_many_to_one_mapping_references : RelationshipPairingVisitorSpec
-    {
         public override void establish_context()
         {
-            manyToOneYToHolder = new ManyToOneMapping();
-            manyToOneYToHolder.Set(x => x.Class, Layer.Defaults, new TypeReference(typeof(Holder)));
-            manyToOneYToHolder.Set(x => x.Name, Layer.Defaults, "ARankedFirstProperty");
-            manyToOneYToHolder.ContainingEntityType = typeof(ARankedFirst);
-            manyToOneYToHolder.Member = new PropertyMember(typeof(ARankedFirst).GetProperty("ARankedFirstProperty"));
-
-            manyToOneZToHolder = new ManyToOneMapping();
-            manyToOneZToHolder.Set(x => x.Class, Layer.Defaults, new TypeReference(typeof(Holder)));
-            manyToOneZToHolder.Set(x => x.Name, Layer.Defaults, "BRankedSecondProperty");
-            manyToOneZToHolder.ContainingEntityType = typeof(BRankedSecond);
-            manyToOneZToHolder.Member = new PropertyMember(typeof(BRankedSecond).GetProperty("BRankedSecondProperty"));
+            manyToOneARankedFirstToHolder = new ManyToOneMapping();
+            manyToOneARankedFirstToHolder.Set(x => x.Class, Layer.Defaults, new TypeReference(typeof(Holder)));
+            manyToOneARankedFirstToHolder.Set(x => x.Name, Layer.Defaults, "ARankedFirstProperty");
+            manyToOneARankedFirstToHolder.ContainingEntityType = typeof(ARankedFirst);
+            manyToOneARankedFirstToHolder.Member = new PropertyMember(typeof(ARankedFirst).GetProperty("ARankedFirstProperty"));
+
+            manyToOneBRankedSecondToHolder = new ManyToOneMapping();
+            manyToOneBRankedSecondToHolder.Set(x => x.Class, Layer.Defaults, new TypeReference(typeof(Holder)));
+            manyToOneBRankedSecondToHolder.Set(x => x.Name, Layer.Defaults, "BRankedSecondProperty");
+            manyToOneBRankedSecondToHolder.ContainingEntityType = typeof(BRankedSecond);
+            manyToOneBRankedSecondToHolder.Member = new PropertyMember(typeof(BRankedSecond).GetProperty("BRankedSecondProperty"));
 
             var relationship = new OneToManyMapping();
             relationship.Set(x => x.Class, Layer.Defaults, new TypeReference(typeof(BRankedSecond)));
             relationship.ContainingEntityType = typeof(Holder);
 
-            collectionMappingToZ = CollectionMapping.Bag();
-            collectionMappingToZ.Set(x => x.ChildType, Layer.Defaults, typeof(BRankedSecond));
-            collectionMappingToZ.Set(x => x.Name, Layer.Defaults, "ColectionOfBRankedSeconds");
-            collectionMappingToZ.Set(x => x.Relationship, Layer.Defaults, relationship);
-            collectionMappingToZ.ContainingEntityType = typeof(Holder);
+            collectionMappingToBRankedSecond = CollectionMapping.Bag();
+            collectionMappingToBRankedSecond.Set(x => x.ChildType, Layer.Defaults, typeof(BRankedSecond));
+            collectionMappingToBRankedSecond.Set(x => x.Name, Layer.Defaults, "ColectionOfBRankedSeconds");
+            collectionMappingToBRankedSecond.Set(x => x.Relationship, Layer.Defaults, relationship);
+            collectionMappingToBRankedSecond.ContainingEntityType = typeof(Holder);
 
             visitor = new RelationshipPairingVisitor(A.Fake<PairBiDirectionalManyToManySidesDelegate>());
         }
 
         [Test]
         public void should_associate_the_collection_mapping_to_the_correct_type()
         {
-            visitor.ProcessCollection(collectionMappingToZ);
-            visitor.ProcessManyToOne(manyToOneYToHolder);
-            visitor.ProcessManyToOne(manyToOneZToHolder);
+            visitor.ProcessCollection(collectionMappingToBRankedSecond);
+            visitor.ProcessManyToOne(manyToOneARankedFirstToHolder);
+            visitor.ProcessManyToOne(manyToOneBRankedSecondToHolder);
             visitor.Visit(Enumerable.Empty<HibernateMapping>());
 
-            var otherSide = (ManyToOneMapping)collectionMappingToZ.OtherSide;
+            var otherSide = (ManyToOneMapping)collectionMappingToBRankedSecond.OtherSide;
             otherSide.ContainingEntityType.ShouldEqual(typeof(BRankedSecond));
         }
     }
-}
+}