Use Array.Empty<T>() to efficiently create empty arrays (#570)

+semver:patch

Author: deepsource-autofix[bot]

src/FluentNHibernate.Specs/Visitors/BiDirectionalManyToManyPairingVisitorSpecs.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Linq.Expressions;
 using FluentNHibernate.MappingModel;
@@ -283,7 +283,7 @@ protected static CollectionMapping collection<T>(Expression<Func<T, object>> exp
         protected static void Visit(params CollectionMapping[] mappings)
         {
             mappings.Each(visitor.Visit);
-            visitor.Visit(new HibernateMapping[0]); // simulate end of visit
+            visitor.Visit(Array.Empty<HibernateMapping>()); // simulate end of visit
         }
     }
 

src/FluentNHibernate.Testing/Diagnostics/DiagnosticMessageDespatcherTests.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using FakeItEasy;
 using FluentNHibernate.Diagnostics;
 using FluentNHibernate.Testing.Utils;
@@ -22,7 +22,7 @@ public void should_publish_results_to_all_listeners()
         {
             var firstListener = A.Fake<IDiagnosticListener>();
             var secondListener = A.Fake<IDiagnosticListener>();
-            var results = new DiagnosticResults(new ScannedSource[0], new Type[0], new Type[0], new SkippedAutomappingType[0], new Type[0], new AutomappingType[0]);
+            var results = new DiagnosticResults(Array.Empty<ScannedSource>(), Array.Empty<Type>(), Array.Empty<Type>(), Array.Empty<SkippedAutomappingType>(), Array.Empty<Type>(), Array.Empty<AutomappingType>());
 
             dispatcher.RegisterListener(firstListener);
             dispatcher.RegisterListener(secondListener);

src/FluentNHibernate.Testing/Diagnostics/StringLambdaOutputListenerTests.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using FakeItEasy;
 using FluentNHibernate.Diagnostics;
 using FluentNHibernate.Testing.Utils;
@@ -12,7 +12,7 @@ public class StringLambdaOutputListenerTests
         [Test]
         public void should_format_results()
         {
-            var results = new DiagnosticResults(new ScannedSource[0], new Type[0], new Type[0], new SkippedAutomappingType[0], new Type[0], new AutomappingType[0]);
+            var results = new DiagnosticResults(Array.Empty<ScannedSource>(), Array.Empty<Type>(), Array.Empty<Type>(), Array.Empty<SkippedAutomappingType>(), Array.Empty<Type>(), Array.Empty<AutomappingType>());
             var formatter = A.Fake<IDiagnosticResultsFormatter>();
             var listener = new StringLambdaOutputListener(x => { });
             listener.SetFormatter(formatter);
@@ -24,7 +24,7 @@ public void should_format_results()
         [Test]
         public void should_raise_formatted_results()
         {
-            var results = new DiagnosticResults(new ScannedSource[0], new Type[0], new Type[0], new SkippedAutomappingType[0], new Type[0], new AutomappingType[0]);
+            var results = new DiagnosticResults(Array.Empty<ScannedSource>(), Array.Empty<Type>(), Array.Empty<Type>(), Array.Empty<SkippedAutomappingType>(), Array.Empty<Type>(), Array.Empty<AutomappingType>());
             var output = "formatted output";
             var receivedOutput = "";
             var formatter = A.Fake<IDiagnosticResultsFormatter>();

src/FluentNHibernate.Testing/EmptySource.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using FluentNHibernate.Diagnostics;
 
@@ -8,7 +8,7 @@ internal class EmptySource : ITypeSource
     {
         public IEnumerable<Type> GetTypes()
         {
-            return new Type[0];
+            return Array.Empty<Type>();
         }
 
         public void LogSource(IDiagnosticLogger logger)

src/FluentNHibernate.Testing/Visitors/ComponentReferenceResolutionVisitorSpecs.cs

@@ -1,4 +1,5 @@
-using FakeItEasy;
+using System;
+using FakeItEasy;
 using FluentNHibernate.Mapping.Providers;
 using FluentNHibernate.MappingModel;
 using FluentNHibernate.MappingModel.ClassBased;
@@ -44,7 +45,7 @@ public class when_the_component_reference_resolution_visitor_processes_a_compone
     {
         public override void establish_context()
         {
-            visitor = new ComponentReferenceResolutionVisitor(new[] { new ComponentMapComponentReferenceResolver() }, new IExternalComponentMappingProvider[0]);
+            visitor = new ComponentReferenceResolutionVisitor(new[] { new ComponentMapComponentReferenceResolver() }, Array.Empty<IExternalComponentMappingProvider>());
             memberProperty = new DummyPropertyInfo("Component", typeof(ComponentTarget)).ToMember();
         }
 

src/FluentNHibernate/Automapping/AutoMapping.cs

@@ -111,7 +111,7 @@ IPropertyIgnorer IPropertyIgnorer.IgnoreProperty(string name)
 
         IPropertyIgnorer IPropertyIgnorer.IgnoreProperties(string first, params string[] others)
         {
-            var options = (others ?? new string[0]).Concat(new[] { first }).ToArray();
+            var options = (others ?? Array.Empty<string>()).Concat(new[] { first }).ToArray();
 
             ((IPropertyIgnorer)this).IgnoreProperties(x => x.Name.In(options));
 

src/FluentNHibernate/DummyMethodInfo.cs

@@ -22,7 +22,7 @@ public override Type ReturnType
 
         public override object[] GetCustomAttributes(bool inherit)
         {
-            return new object[0];
+            return Array.Empty<object>();
         }
 
         public override bool IsDefined(Type attributeType, bool inherit)
@@ -32,7 +32,7 @@ public override bool IsDefined(Type attributeType, bool inherit)
 
         public override ParameterInfo[] GetParameters()
         {
-            return new ParameterInfo[0];
+            return Array.Empty<ParameterInfo>();
         }
 
         public override MethodImplAttributes GetMethodImplementationFlags()
@@ -82,7 +82,7 @@ public override MethodAttributes Attributes
 
         public override object[] GetCustomAttributes(Type attributeType, bool inherit)
         {
-            return new object[0];
+            return Array.Empty<object>();
         }
     }
 }

src/FluentNHibernate/DummyPropertyInfo.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Globalization;
 using System.Reflection;
 
@@ -31,7 +31,7 @@ public override int MetadataToken
 
         public override object[] GetCustomAttributes(bool inherit)
         {
-            return new object[0];
+            return Array.Empty<object>();
         }
 
         public override bool IsDefined(Type attributeType, bool inherit)
@@ -49,7 +49,7 @@ public override void SetValue(object obj, object value, BindingFlags invokeAttr,
 
         public override MethodInfo[] GetAccessors(bool nonPublic)
         {
-            return new MethodInfo[0];
+            return Array.Empty<MethodInfo>();
         }
 
         public override MethodInfo GetGetMethod(bool nonPublic)
@@ -64,7 +64,7 @@ public override MethodInfo GetSetMethod(bool nonPublic)
 
         public override ParameterInfo[] GetIndexParameters()
         {
-            return new ParameterInfo[0];
+            return Array.Empty<ParameterInfo>();
         }
 
         public override string Name
@@ -104,7 +104,7 @@ public override bool CanWrite
 
         public override object[] GetCustomAttributes(Type attributeType, bool inherit)
         {
-            return new object[0];
+            return Array.Empty<object>();
         }
     }
 }

src/FluentNHibernate/Mapping/ClassMap.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Linq.Expressions;
@@ -724,7 +724,7 @@ string GetDefaultTableName()
 
         IEnumerable<Member> IMappingProvider.GetIgnoredProperties()
         {
-            return new Member[0];
+            return Array.Empty<Member>();
         }
     }
 }

src/FluentNHibernate/MappingModel/TypeReference.cs

@@ -99,7 +99,7 @@ public bool IsNullable
         public Type[] GetGenericArguments()
         {
             if (innerType == null)
-                return new Type[0];
+                return Array.Empty<Type>();
 
             return innerType.GetGenericArguments();
         }