Skip to content

Commit eed20a2

Browse files
authored
Mark Sql* methods on components as obsolete & hide from editor (#754)
Fixes #119 +semver:feature
1 parent 50deb12 commit eed20a2

File tree

2 files changed

+19
-4
lines changed

2 files changed

+19
-4
lines changed

src/FluentNHibernate/Mapping/ClasslikeMapBase.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,7 @@ public ManyToManyPart<TChild> HasManyToMany<TChild>(Expression<Func<T, object>>
401401
/// Specify an insert stored procedure
402402
/// </summary>
403403
/// <param name="innerText">Stored procedure call</param>
404-
public StoredProcedurePart SqlInsert(string innerText)
404+
public virtual StoredProcedurePart SqlInsert(string innerText)
405405
{
406406
return StoredProcedure("sql-insert", innerText);
407407
}
@@ -410,7 +410,7 @@ public StoredProcedurePart SqlInsert(string innerText)
410410
/// Specify an update stored procedure
411411
/// </summary>
412412
/// <param name="innerText">Stored procedure call</param>
413-
public StoredProcedurePart SqlUpdate(string innerText)
413+
public virtual StoredProcedurePart SqlUpdate(string innerText)
414414
{
415415
return StoredProcedure("sql-update", innerText);
416416
}
@@ -419,7 +419,7 @@ public StoredProcedurePart SqlUpdate(string innerText)
419419
/// Specify an delete stored procedure
420420
/// </summary>
421421
/// <param name="innerText">Stored procedure call</param>
422-
public StoredProcedurePart SqlDelete(string innerText)
422+
public virtual StoredProcedurePart SqlDelete(string innerText)
423423
{
424424
return StoredProcedure("sql-delete", innerText);
425425
}
@@ -428,7 +428,7 @@ public StoredProcedurePart SqlDelete(string innerText)
428428
/// Specify an delete all stored procedure
429429
/// </summary>
430430
/// <param name="innerText">Stored procedure call</param>
431-
public StoredProcedurePart SqlDeleteAll(string innerText)
431+
public virtual StoredProcedurePart SqlDeleteAll(string innerText)
432432
{
433433
return StoredProcedure("sql-delete-all", innerText);
434434
}

src/FluentNHibernate/Mapping/ComponentPartBase.cs

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
using System;
2+
using System.ComponentModel;
23
using System.Diagnostics;
34
using System.Linq.Expressions;
45
using FluentNHibernate.MappingModel;
@@ -189,4 +190,18 @@ protected ComponentMapping CreateComponentMapping()
189190

190191
return mapping;
191192
}
193+
194+
#pragma warning disable CS0809 // Obsolete member overrides non-obsolete member
195+
[Obsolete("SqlInsert is not supported on components"), EditorBrowsable(EditorBrowsableState.Never)]
196+
public override StoredProcedurePart SqlInsert(string innerText) => base.SqlInsert(innerText);
197+
198+
[Obsolete("SqlUpdate is not supported on components"), EditorBrowsable(EditorBrowsableState.Never)]
199+
public override StoredProcedurePart SqlUpdate(string innerText) => base.SqlUpdate(innerText);
200+
201+
[Obsolete("SqlDelete is not supported on components"), EditorBrowsable(EditorBrowsableState.Never)]
202+
public override StoredProcedurePart SqlDelete(string innerText) => base.SqlDelete(innerText);
203+
204+
[Obsolete("SqlDeleteAll is not supported on components"), EditorBrowsable(EditorBrowsableState.Never)]
205+
public override StoredProcedurePart SqlDeleteAll(string innerText) => base.SqlDeleteAll(innerText);
206+
#pragma warning restore CS0809 // Obsolete member overrides non-obsolete member
192207
}

0 commit comments

Comments
 (0)