Update NHibernate to 5.3.3 (#475)

+semver:feature

Author: hazzik

src/Directory.Build.props

@@ -39,7 +39,7 @@
   </PropertyGroup>
 
   <PropertyGroup Label="Package Versions">
-    <NHibernatePackageVersion>5.2.7</NHibernatePackageVersion>
+    <NHibernatePackageVersion>5.3.3</NHibernatePackageVersion>
   </PropertyGroup>
 
   <ItemGroup Condition="'$(IsPackable)' == 'true'">

src/FluentNHibernate.Testing/Cfg/Db/OracleClientConfigurationTester.cs

@@ -1,12 +1,12 @@
+using System;
 using FluentNHibernate.Cfg.Db;
-using NHibernate;
 using NHibernate.Dialect;
 using NHibernate.Driver;
 using NUnit.Framework;
 
 namespace FluentNHibernate.Testing.Cfg.Db
 {
-    [TestFixture]
+    [TestFixture, Obsolete]
     public class OracleClientConfigurationTester
     {
         [Test]

src/FluentNHibernate.Testing/Cfg/Db/OracleDataClientConfigurationTester.cs

@@ -46,7 +46,7 @@ public void ConnectionString_is_added_to_the_configuration()
         [Test]
         public void ConnectionString_leaving_out_the_StatementCacheSize_removes_from_string()
         {
-            OracleClientConfiguration.Oracle9
+            OracleDataClientConfiguration.Oracle9
                .ConnectionString(c => c
                    .Server("db-srv")
                    .Instance("mydatabase")
@@ -59,7 +59,7 @@ public void ConnectionString_leaving_out_the_StatementCacheSize_removes_from_str
         [Test]
         public void ConnectionString_pooling_defaults_to_false_when_not_set()
         {
-            OracleClientConfiguration.Oracle9
+            OracleDataClientConfiguration.Oracle9
              .ConnectionString(c => c
                  .Server("db-srv")
                  .Instance("mydatabase")

src/FluentNHibernate.Testing/Cfg/Db/OracleManagedDataClientConfigurationTester.cs

@@ -46,7 +46,7 @@ public void ConnectionString_is_added_to_the_configuration()
       [Test]
       public void ConnectionString_leaving_out_the_StatementCacheSize_removes_from_string()
       {
-         OracleClientConfiguration.Oracle9
+          OracleManagedDataClientConfiguration.Oracle9
             .ConnectionString(c => c
                .Server("db-srv")
                .Instance("mydatabase")
@@ -59,7 +59,7 @@ public void ConnectionString_leaving_out_the_StatementCacheSize_removes_from_str
       [Test]
       public void ConnectionString_pooling_defaults_to_false_when_not_set()
       {
-         OracleClientConfiguration.Oracle9
+          OracleManagedDataClientConfiguration.Oracle9
             .ConnectionString(c => c
                .Server("db-srv")
                .Instance("mydatabase")

src/FluentNHibernate/Cfg/Db/OracleClientConfiguration.cs

@@ -1,8 +1,10 @@
+using System;
 using NHibernate.Dialect;
 using NHibernate.Driver;
 
 namespace FluentNHibernate.Cfg.Db
 {
+    [Obsolete("Use OracleManagedDataClientConfiguration or OracleDataClientConfiguration instead.")]
     public class OracleClientConfiguration : PersistenceConfiguration<OracleClientConfiguration, OracleConnectionStringBuilder>
     {
         protected OracleClientConfiguration()

src/FluentNHibernate/Testing/PersistenceSpecification.cs

@@ -31,7 +31,9 @@ public PersistenceSpecification(ISession session)
         public PersistenceSpecification(ISession session, IEqualityComparer entityEqualityComparer)
         {
             currentSession = session;
+#pragma warning disable CS0618 // ISession.Transaction is obsolete
             hasExistingTransaction = currentSession.Transaction != null && currentSession.Transaction.IsActive || System.Transactions.Transaction.Current != null;
+#pragma warning restore CS0618
             this.entityEqualityComparer = entityEqualityComparer;
         }