Revert "Modified ReferenceComponentMapping to pass visitors through to the underlying ExternalComponentMapping. Also modified ExternalComponentMapping to prevent it from running a visitor more than once."

This reverts commit 35609a0.

Author: paulbatum

src/FluentNHibernate.Specs/Conventions/PropertyConventionSpecs.cs

@@ -135,7 +135,6 @@
     <Compile Include="Automapping\OverrideSpecs.cs" />
     <Compile Include="Conventions\BiDirectionalKeysSpecs.cs" />
     <Compile Include="Conventions\Fixtures\Parent.cs" />
-    <Compile Include="Conventions\PropertyConventionSpecs.cs" />
     <Compile Include="PersistenceModel\Fixtures\UnionChildEntity.cs" />
     <Compile Include="PersistenceModel\Fixtures\UnionChildEntityMap.cs" />
     <Compile Include="PersistenceModel\Fixtures\UnionEntity.cs" />

src/FluentNHibernate.Specs/FluentNHibernate.Specs.csproj

@@ -1,6 +1,4 @@
 using System;
-using FluentNHibernate.Visitors;
-using System.Collections.Generic;
 
 namespace FluentNHibernate.MappingModel.ClassBased
 {
@@ -17,18 +15,5 @@ public ExternalComponentMapping(ComponentType componentType)
         public ExternalComponentMapping(ComponentType componentType, AttributeStore underlyingStore)
             : base(componentType, underlyingStore)
         {}
-
-        private readonly IList<IMappingModelVisitor> previousVisitors = new List<IMappingModelVisitor>();
-
-        public override void AcceptVisitor(IMappingModelVisitor visitor)
-        {
-            // This external mapping might be shared amongst several ReferenceComponentMappings. Allowing a particular visitor to be applied to this component mapping
-            // more than once can cause issues, so lets ensure that doesn't happen.
-            if(previousVisitors.Contains(visitor))
-                return;
-
-            previousVisitors.Add(visitor);
-            base.AcceptVisitor(visitor);
-        }
     }
 }

src/FluentNHibernate/MappingModel/ClassBased/ExternalComponentMapping.cs

@@ -32,9 +32,6 @@ public ReferenceComponentMapping(ComponentType componentType, Member property, T
         public void AcceptVisitor(IMappingModelVisitor visitor)
         {
             visitor.ProcessComponent(this);
-
-            if(mergedComponent != null)
-                visitor.Visit(mergedComponent);
         }
 
         public bool IsSpecified(string name)