Skip to content

Commit 03a19ac

Browse files
committed
Add failure messages back into unit test
This is addressing a comment by user bahusoid on my previous PR
1 parent e3b245c commit 03a19ac

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/NHibernate.Test/Hql/SimpleFunctionsTest.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public void CastFunc()
5656
args.Clear();
5757
args.Add("'123'");
5858
args.Add("NO_TYPE");
59-
Assert.Throws<QueryException>(() => cf.Render(args, factoryImpl));
59+
Assert.Throws<QueryException>(() => cf.Render(args, factoryImpl), "Invalid type accepted");
6060
}
6161

6262
[Test]
@@ -115,7 +115,7 @@ public void ClassicSum()
115115
{
116116
//ANSI-SQL92 definition
117117
//<general set function> ::=
118-
//<set function type> <leftparen> [ <setquantifier> ] <value expression> <right paren>
118+
//<set function type> <left paren> [ <setquantifier> ] <value expression> <right paren>
119119
//<set function type> : := AVG | MAX | MIN | SUM | COUNT
120120
//<setquantifier> ::= DISTINCT | ALL
121121
IList args = new ArrayList();
@@ -153,7 +153,7 @@ public void ClassicCount()
153153
args.Clear();
154154
args.Add("va1");
155155
args.Add("va2");
156-
Assert.Throws<QueryException>(() => ccf.Render(args, factoryImpl));
156+
Assert.Throws<QueryException>(() => ccf.Render(args, factoryImpl), "No exception 2 argument without <setquantifier>");
157157
}
158158

159159
[Test]
@@ -178,7 +178,7 @@ public void ClassicAvg()
178178
args.Clear();
179179
args.Add("va1");
180180
args.Add("va2");
181-
Assert.Throws<QueryException>(() => caf.Render(args, factoryImpl));
181+
Assert.Throws<QueryException>(() => caf.Render(args, factoryImpl), "No exception 2 argument without <setquantifier>");
182182
}
183183

184184
[Test]
@@ -198,7 +198,7 @@ public void ClassicAggregate()
198198
args.Clear();
199199
args.Add("va1");
200200
args.Add("va2");
201-
Assert.Throws<QueryException>(() => caf.Render(args, factoryImpl));
201+
Assert.Throws<QueryException>(() => caf.Render(args, factoryImpl), "No exception 2 argument without <setquantifier>");
202202

203203
args.Clear();
204204
args.Add("*");
@@ -223,13 +223,13 @@ public void AnsiSubstring()
223223
Assert.AreEqual("substring(var1 from 3 for 4)", asf.Render(args, factoryImpl).ToString());
224224

225225
args.Clear();
226-
Assert.Throws<QueryException>(() => asf.Render(args, factoryImpl));
226+
Assert.Throws<QueryException>(() => asf.Render(args, factoryImpl), "Expected 'Not enough parameters' exception");
227227
args.Clear();
228228
args.Add("1");
229229
args.Add("2");
230230
args.Add("3");
231231
args.Add("4");
232-
Assert.Throws<QueryException>(() => asf.Render(args, factoryImpl));
232+
Assert.Throws<QueryException>(() => asf.Render(args, factoryImpl), "Expected 'Not enough parameters' exception");
233233
}
234234
}
235235
}

0 commit comments

Comments
 (0)