NH-3679 fix SchemaExport to file using SetOutputFile and Create

Unit test and proposed fix for NH-3679

Author: Stefan Buehler

src/NHibernate.Test/NHSpecificTest/NH3679/ExportToFileFixture.cs

@@ -0,0 +1,50 @@
+using System;
+using System.Collections.Generic;
+using System.IO;
+using System.Linq;
+using System.Text;
+using NHibernate.Test.NHSpecificTest.NH2756;
+using NUnit.Framework;
+using NHibernate.Tool.hbm2ddl;
+using File = System.IO.File;
+
+namespace NHibernate.Test.NHSpecificTest.NH3679
+{
+    public class ExportToFileFixture
+    {
+        [Test]
+        public void ExportToFileUsingSetOutputFileAndCreate()
+        {
+            var configuration = TestConfigurationHelper.GetDefaultConfiguration();
+
+            configuration.AddResource("NHibernate.Test.Tools.hbm2ddl.SchemaMetadataUpdaterTest.HeavyEntity.hbm.xml",
+                                                                GetType().Assembly);
+            
+            var outputFileName = Path.GetTempFileName();
+            var export = new SchemaExport(configuration);
+            export.SetOutputFile(outputFileName);
+
+            export.Create(false, false);
+
+            Assert.IsTrue(File.Exists(outputFileName));
+            Assert.IsTrue(new FileInfo(outputFileName).Length > 0);
+        }
+
+        [Test]
+        public void ExportToFileUsingExecute()
+        {
+            var configuration = TestConfigurationHelper.GetDefaultConfiguration();
+
+            configuration.AddResource("NHibernate.Test.Tools.hbm2ddl.SchemaMetadataUpdaterTest.HeavyEntity.hbm.xml",
+                                                                GetType().Assembly);
+            
+            var outputFileName = Path.GetTempFileName();
+            var export = new SchemaExport(configuration);
+
+            export.Execute(null, false, false, new StreamWriter(outputFileName));
+
+            Assert.IsTrue(File.Exists(outputFileName));
+            Assert.IsTrue(new FileInfo(outputFileName).Length > 0);
+        }
+    }
+}

src/NHibernate.Test/NHibernate.Test.csproj

@@ -792,6 +792,7 @@
     </Compile>
     <Compile Include="NHSpecificTest\NH3202\Domain.cs" />
     <Compile Include="NHSpecificTest\NH3202\Fixture.cs" />
+    <Compile Include="NHSpecificTest\NH3679\ExportToFileFixture.cs" />
     <Compile Include="NHSpecificTest\NH646\Domain.cs" />
     <Compile Include="NHSpecificTest\NH646\Fixture.cs" />
     <Compile Include="NHSpecificTest\NH3234\Fixture.cs" />

src/NHibernate/Tool/hbm2ddl/SchemaExport.cs

@@ -344,7 +344,7 @@ public void Execute(Action<string> scriptAction, bool execute, bool justDrop, Te
 
 			try
 			{
-				if (fileOutput != null && outputFile != null)
+				if (fileOutput == null && outputFile != null)
 				{
 					fileOutput = new StreamWriter(outputFile);
 				}