fixup! Support evaluation of Random.Next and NextDouble on db side

Hack the test for dodging a Firebird limitation combined with a wicked
driver hack attempting to work around this limitation.

Author: fredericDelaporte

src/NHibernate.Test/Async/Linq/PreEvaluationTests.cs

@@ -265,7 +265,13 @@ public async Task CanQueryByRandomIntAsync()
 			using (var spy = new SqlLogSpy())
 			{
 				var random = new Random();
-				var x = await (db.Orders.CountAsync(o => o.OrderId - idMin - 1 < random.Next()));
+				// Dodge a Firebird driver limitation by putting the constants before the order id.
+				// This driver cast parameters to their types in some cases for avoiding Firebird complaining of not
+				// knowing the type of the condition. For some reasons the driver considers the casting should not be
+				// done next to the conditional operator. Having the cast only on one side is enough for avoiding
+				// Firebird complain, so moving the constants on the left side have been put before the order id, in
+				// order for these constants to be casted by the driver.
+				var x = await (db.Orders.CountAsync(o => -idMin - 1 + o.OrderId < random.Next()));
 
 				Assert.That(x, Is.GreaterThan(0));
 				// Next requires support of both floor and rand
@@ -309,7 +315,13 @@ public async Task CanQueryByRandomIntWithMaxAsync()
 			using (var spy = new SqlLogSpy())
 			{
 				var random = new Random();
-				var x = await (db.Orders.CountAsync(o => o.OrderId - idMin < random.Next(10)));
+				// Dodge a Firebird driver limitation by putting the constants before the order id.
+				// This driver cast parameters to their types in some cases for avoiding Firebird complaining of not
+				// knowing the type of the condition. For some reasons the driver considers the casting should not be
+				// done next to the conditional operator. Having the cast only on one side is enough for avoiding
+				// Firebird complain, so moving the constants on the left side have been put before the order id, in
+				// order for these constants to be casted by the driver.
+				var x = await (db.Orders.CountAsync(o => -idMin + o.OrderId < random.Next(10)));
 
 				Assert.That(x, Is.GreaterThan(0).And.LessThan(10));
 				// Next requires support of both floor and rand
@@ -353,7 +365,13 @@ public async Task CanQueryByRandomIntWithMinMaxAsync()
 			using (var spy = new SqlLogSpy())
 			{
 				var random = new Random();
-				var x = await (db.Orders.CountAsync(o => o.OrderId - idMin < random.Next(1, 11)));
+				// Dodge a Firebird driver limitation by putting the constants before the order id.
+				// This driver cast parameters to their types in some cases for avoiding Firebird complaining of not
+				// knowing the type of the condition. For some reasons the driver considers the casting should not be
+				// done next to the conditional operator. Having the cast only on one side is enough for avoiding
+				// Firebird complain, so moving the constants on the left side have been put before the order id, in
+				// order for these constants to be casted by the driver.
+				var x = await (db.Orders.CountAsync(o => -idMin + o.OrderId< random.Next(1, 11)));
 
 				Assert.That(x, Is.GreaterThan(0).And.LessThan(10));
 				// Next requires support of both floor and rand

src/NHibernate.Test/Linq/PreEvaluationTests.cs

@@ -253,7 +253,13 @@ public void CanQueryByRandomInt()
 			using (var spy = new SqlLogSpy())
 			{
 				var random = new Random();
-				var x = db.Orders.Count(o => o.OrderId - idMin - 1 < random.Next());
+				// Dodge a Firebird driver limitation by putting the constants before the order id.
+				// This driver cast parameters to their types in some cases for avoiding Firebird complaining of not
+				// knowing the type of the condition. For some reasons the driver considers the casting should not be
+				// done next to the conditional operator. Having the cast only on one side is enough for avoiding
+				// Firebird complain, so moving the constants on the left side have been put before the order id, in
+				// order for these constants to be casted by the driver.
+				var x = db.Orders.Count(o => -idMin - 1 + o.OrderId < random.Next());
 
 				Assert.That(x, Is.GreaterThan(0));
 				// Next requires support of both floor and rand
@@ -297,7 +303,13 @@ public void CanQueryByRandomIntWithMax()
 			using (var spy = new SqlLogSpy())
 			{
 				var random = new Random();
-				var x = db.Orders.Count(o => o.OrderId - idMin < random.Next(10));
+				// Dodge a Firebird driver limitation by putting the constants before the order id.
+				// This driver cast parameters to their types in some cases for avoiding Firebird complaining of not
+				// knowing the type of the condition. For some reasons the driver considers the casting should not be
+				// done next to the conditional operator. Having the cast only on one side is enough for avoiding
+				// Firebird complain, so moving the constants on the left side have been put before the order id, in
+				// order for these constants to be casted by the driver.
+				var x = db.Orders.Count(o => -idMin + o.OrderId < random.Next(10));
 
 				Assert.That(x, Is.GreaterThan(0).And.LessThan(10));
 				// Next requires support of both floor and rand
@@ -341,7 +353,13 @@ public void CanQueryByRandomIntWithMinMax()
 			using (var spy = new SqlLogSpy())
 			{
 				var random = new Random();
-				var x = db.Orders.Count(o => o.OrderId - idMin < random.Next(1, 11));
+				// Dodge a Firebird driver limitation by putting the constants before the order id.
+				// This driver cast parameters to their types in some cases for avoiding Firebird complaining of not
+				// knowing the type of the condition. For some reasons the driver considers the casting should not be
+				// done next to the conditional operator. Having the cast only on one side is enough for avoiding
+				// Firebird complain, so moving the constants on the left side have been put before the order id, in
+				// order for these constants to be casted by the driver.
+				var x = db.Orders.Count(o => -idMin + o.OrderId< random.Next(1, 11));
 
 				Assert.That(x, Is.GreaterThan(0).And.LessThan(10));
 				// Next requires support of both floor and rand