Skip to content

Commit 3957fc0

Browse files
committed
Make tests for NH-2736 applicable only to dialects which support variable limits
1 parent 80358ba commit 3957fc0

File tree

1 file changed

+15
-13
lines changed
  • src/NHibernate.Test/NHSpecificTest/NH2736

1 file changed

+15
-13
lines changed

src/NHibernate.Test/NHSpecificTest/NH2736/Fixture.cs

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,38 +5,42 @@ namespace NHibernate.Test.NHSpecificTest.NH2736
55
[TestFixture]
66
public class Fixture : BugTestCase
77
{
8+
protected override bool AppliesTo(Dialect.Dialect dialect)
9+
{
10+
return dialect.SupportsVariableLimit;
11+
}
12+
813
protected override void OnSetUp()
914
{
10-
base.OnSetUp();
11-
using (ISession session = Sfi.OpenSession())
12-
using (ITransaction transaction = session.BeginTransaction())
15+
using (var session = Sfi.OpenSession())
16+
using (var transaction = session.BeginTransaction())
1317
{
1418
{
15-
SalesOrder order = new SalesOrder() { Number = 1 };
19+
var order = new SalesOrder { Number = 1 };
1620
order.Items.Add(new Item { SalesOrder = order, Quantity = 1 });
1721
order.Items.Add(new Item { SalesOrder = order, Quantity = 2 });
1822
order.Items.Add(new Item { SalesOrder = order, Quantity = 3 });
1923
order.Items.Add(new Item { SalesOrder = order, Quantity = 4 });
2024
session.Persist(order);
2125
}
2226
{
23-
SalesOrder order = new SalesOrder() { Number = 2 };
27+
var order = new SalesOrder { Number = 2 };
2428
order.Items.Add(new Item { SalesOrder = order, Quantity = 1 });
2529
order.Items.Add(new Item { SalesOrder = order, Quantity = 2 });
2630
order.Items.Add(new Item { SalesOrder = order, Quantity = 3 });
2731
order.Items.Add(new Item { SalesOrder = order, Quantity = 4 });
2832
session.Persist(order);
2933
}
3034
{
31-
SalesOrder order = new SalesOrder() { Number = 3 };
35+
var order = new SalesOrder { Number = 3 };
3236
order.Items.Add(new Item { SalesOrder = order, Quantity = 1 });
3337
order.Items.Add(new Item { SalesOrder = order, Quantity = 2 });
3438
order.Items.Add(new Item { SalesOrder = order, Quantity = 3 });
3539
order.Items.Add(new Item { SalesOrder = order, Quantity = 4 });
3640
session.Persist(order);
3741
}
3842
{
39-
SalesOrder order = new SalesOrder() { Number = 4 };
43+
var order = new SalesOrder { Number = 4 };
4044
order.Items.Add(new Item { SalesOrder = order, Quantity = 1 });
4145
order.Items.Add(new Item { SalesOrder = order, Quantity = 2 });
4246
order.Items.Add(new Item { SalesOrder = order, Quantity = 3 });
@@ -49,22 +53,20 @@ protected override void OnSetUp()
4953

5054
protected override void OnTearDown()
5155
{
52-
using (ISession session = Sfi.OpenSession())
53-
using (ITransaction transaction = session.BeginTransaction())
56+
using (var session = Sfi.OpenSession())
57+
using (var transaction = session.BeginTransaction())
5458
{
5559
session.CreateQuery("delete from Item").ExecuteUpdate();
5660
session.CreateQuery("delete from SalesOrder").ExecuteUpdate();
5761
transaction.Commit();
5862
}
59-
60-
base.OnTearDown();
6163
}
6264

6365
[Test]
6466
public void TestHqlParametersWithTake()
6567
{
66-
using (ISession session = Sfi.OpenSession())
67-
using (ITransaction transaction = session.BeginTransaction())
68+
using (var session = Sfi.OpenSession())
69+
using (session.BeginTransaction())
6870
{
6971
var query = session.CreateQuery("select o.Id, i.Id from SalesOrder o left join o.Items i with i.Quantity = :pQuantity take :pTake");
7072
query.SetParameter("pQuantity", 1);

0 commit comments

Comments
 (0)