Ignore unsupported scope usages

Author: fredericDelaporte

src/NHibernate.Test/Async/SystemTransactions/SystemTransactionFixture.cs

@@ -192,11 +192,11 @@ public async Task CanUseSessionWithManyScopesAsync(bool explicitFlush)
 			// being concurrently disposed of. See https://github.com/nhibernate/nhibernate-core/pull/1505 for more details.
 			if (Sfi.ConnectionProvider.Driver is OdbcDriver)
 				Assert.Ignore("ODBC sometimes fails on second scope by checking the previous transaction status, which may yield an object disposed exception");
-			// SAP HANA .Net provider always causes system transactions to be distributed, causing them to complete
-			// on concurrent threads. This creates race conditions when chaining scopes, the subsequent scope usage
+			// SAP HANA & SQL Anywhere .Net provider always causes system transactions to be distributed, causing them to
+			// complete on concurrent threads. This creates race conditions when chaining scopes, the subsequent scope usage
 			// finding the connection still enlisted in the previous transaction, its complete being still not finished
 			// on its own thread.
-			if (Sfi.ConnectionProvider.Driver is HanaDriverBase)
+			if (Sfi.ConnectionProvider.Driver is HanaDriverBase || Sfi.ConnectionProvider.Driver is SapSQLAnywhere17Driver)
 				Assert.Ignore("SAP HANA scope handling causes concurrency issues preventing chaining scope usages.");
 
 			using (var s = WithOptions().ConnectionReleaseMode(ConnectionReleaseMode.OnClose).OpenSession())

src/NHibernate.Test/SystemTransactions/SystemTransactionFixture.cs

@@ -181,11 +181,11 @@ public void CanUseSessionWithManyScopes(bool explicitFlush)
 			// being concurrently disposed of. See https://github.com/nhibernate/nhibernate-core/pull/1505 for more details.
 			if (Sfi.ConnectionProvider.Driver is OdbcDriver)
 				Assert.Ignore("ODBC sometimes fails on second scope by checking the previous transaction status, which may yield an object disposed exception");
-			// SAP HANA .Net provider always causes system transactions to be distributed, causing them to complete
-			// on concurrent threads. This creates race conditions when chaining scopes, the subsequent scope usage
+			// SAP HANA & SQL Anywhere .Net provider always causes system transactions to be distributed, causing them to
+			// complete on concurrent threads. This creates race conditions when chaining scopes, the subsequent scope usage
 			// finding the connection still enlisted in the previous transaction, its complete being still not finished
 			// on its own thread.
-			if (Sfi.ConnectionProvider.Driver is HanaDriverBase)
+			if (Sfi.ConnectionProvider.Driver is HanaDriverBase || Sfi.ConnectionProvider.Driver is SapSQLAnywhere17Driver)
 				Assert.Ignore("SAP HANA scope handling causes concurrency issues preventing chaining scope usages.");
 
 			using (var s = WithOptions().ConnectionReleaseMode(ConnectionReleaseMode.OnClose).OpenSession())

src/NHibernate.Test/SystemTransactions/SystemTransactionFixtureBase.cs

@@ -52,7 +52,11 @@ protected void DisableConnectionAutoEnlist(Configuration configuration)
 		protected void IgnoreIfUnsupported(bool explicitFlush)
 		{
 			Assume.That(
-				new[] { explicitFlush, UseConnectionOnSystemTransactionPrepare },
+				new[]
+				{
+					explicitFlush,
+					UseConnectionOnSystemTransactionPrepare && TestDialect.SupportsUsingConnectionOnSystemTransactionPrepare
+				},
 				Has.Some.EqualTo(true),
 				"Implicit flush cannot work without using connection from system transaction prepare phase");
 		}

src/NHibernate.Test/TestDialect.cs

@@ -138,5 +138,10 @@ public bool SupportsSqlType(SqlType sqlType)
 		/// Even quoted, some databases do not support square bracket in identifiers.
 		/// </summary>
 		public virtual bool SupportsSquareBracketInIdentifiers => true;
+
+		/// <summary>
+		/// Some databases fail when a connection is enlisted during the first phase of a two phase commit.
+		/// </summary>
+		public virtual bool SupportsUsingConnectionOnSystemTransactionPrepare => true;
 	}
 }

src/NHibernate.Test/TestDialects/SapSQLAnywhere17TestDialect.cs

@@ -21,5 +21,11 @@ public SapSQLAnywhere17TestDialect(Dialect.Dialect dialect)
 		/// It seems they have decide to remove this support starting from version 16.
 		/// </remarks>
 		public override bool SupportsSquareBracketInIdentifiers => false;
+
+		/// <inheritdoc />
+		/// <remarks>
+		/// SQL Anywhere freezes on commit and the transaction ends by timeout.
+		/// </remarks>
+		public override bool SupportsUsingConnectionOnSystemTransactionPrepare => false;
 	}
 }