Merge pull request #671 from fredericDelaporte/TestWarnings

Purge tests compilation warnings

Author: fredericDelaporte

src/NHibernate.DomainModel/NHibernate.DomainModel.csproj

@@ -12,6 +12,11 @@
     <NoWarn>$(NoWarn);3001;3002;3003;3005</NoWarn>
   </PropertyGroup>
 
+  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
+    <TreatWarningsAsErrors>True</TreatWarningsAsErrors>
+    <TreatSpecificWarningsAsErrors />
+  </PropertyGroup>
+
   <ItemGroup>
     <None Remove="**\*.hbm.xml" />
   </ItemGroup>

src/NHibernate.Test/Generatedkeys/Identity/MyEntityIdentity.cs

@@ -2,7 +2,10 @@ namespace NHibernate.Test.Generatedkeys.Identity
 {
 	public class MyEntityIdentity
 	{
+		// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 		private int id;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 		private string name;
 
 		public virtual int Id

src/NHibernate.Test/Generatedkeys/Select/MyEntity.cs

@@ -2,7 +2,10 @@ namespace NHibernate.Test.Generatedkeys.Select
 {
 	public class MyEntity
 	{
+		// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 		private int id;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 		private string name;
 		protected MyEntity() {}
 

src/NHibernate.Test/Generatedkeys/Seqidentity/MyEntity.cs

@@ -2,7 +2,10 @@ namespace NHibernate.Test.Generatedkeys.Seqidentity
 {
 	public class MyEntity
 	{
+		// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 		private int id;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 		private string name;
 
 		public virtual int Id

src/NHibernate.Test/Hql/Ast/KeyManyToOneEntity.cs

@@ -4,7 +4,10 @@ namespace NHibernate.Test.Hql.Ast
 {
 	public class KeyManyToOneEntity
 	{
+		// Used by reflection
+#pragma warning disable CS0169 // The field is never used
 		private Id id;
+#pragma warning restore CS0169 // The field is never used
 		private string name;
 
 		public virtual string Name

src/NHibernate.Test/Hql/Ast/KeyManyToOneKeyEntity.cs

@@ -2,7 +2,10 @@ namespace NHibernate.Test.Hql.Ast
 {
 	public class KeyManyToOneKeyEntity
 	{
+		// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 		private long id;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 		private string name;
 		private int? requestedHash;
 

src/NHibernate.Test/IdGen/Enhanced/Forcedtable/Entity.cs

@@ -3,9 +3,10 @@
 	public class Entity
 	{
 
-#pragma warning disable 0414  // unassigned variable
+		// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 		private long _id;
-#pragma warning restore 0414
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 
 		public virtual long Id
 		{

src/NHibernate.Test/IdGen/Enhanced/Sequence/Entity.cs

@@ -2,10 +2,10 @@
 {
 	public class Entity
 	{
-
-#pragma warning disable 0414  // unassigned variable
+		// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value 0
 		private long _id;
-#pragma warning restore 0414
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value 0
 
 		public virtual long Id
 		{

src/NHibernate.Test/IdGen/Enhanced/Table/Entity.cs

@@ -2,10 +2,10 @@ namespace NHibernate.Test.IdGen.Enhanced.Table
 {
 	public class Entity
 	{
-
-#pragma warning disable 0414  // unassigned variable
+		// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 		private long _id;
-#pragma warning restore 0414
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 
 		public virtual long Id
 		{

src/NHibernate.Test/MappingByCode/ConventionModelMapperTests/ComponetsAccessorTests.cs

@@ -10,7 +10,10 @@ public class ComponetsAccessorTests
 		private class MyClass
 		{
 			public int Id { get; set; }
+			// Assigned by reflection
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
 			private MyCompo compo;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 			public MyCompo Compo
 			{
 				get { return compo; }