Added missing methods Abstract and Extents on subclass, joined-subclass and union-subclass, with unit tests

Author: rjperes

src/NHibernate.Test/MappingByCode/ExplicitlyDeclaredModelTests/JoinedSubclassMappingStrategyTests.cs

@@ -79,5 +79,23 @@ public void WhenRegisteredAsJoinedSubclassThenIsEntity()
 
 			Assert.That(inspector.IsEntity(typeof(Inherited1)), Is.True);
 		}
+
+		[Test]
+		public void JoinedSubclassIsAbstract()
+		{
+			//NH-3527
+			var modelMapper = new ModelMapper();
+			modelMapper.Class<MyClass>(c => { });
+			modelMapper.JoinedSubclass<Inherited1>(c =>
+			{
+				c.Abstract(true);
+				c.Extends(typeof(MyClass));
+			});
+
+			var mappings = modelMapper.CompileMappingForAllExplicitlyAddedEntities();
+
+			Assert.IsTrue(mappings.JoinedSubclasses[0].@abstract);
+			Assert.IsTrue(mappings.JoinedSubclasses[0].extends == typeof(MyClass).FullName);
+		}
 	}
 }

src/NHibernate.Test/MappingByCode/ExplicitlyDeclaredModelTests/SubclassMappingStrategyTests.cs

@@ -79,5 +79,23 @@ public void WhenRegisteredAsSubclassThenIsEntity()
 
 			Assert.That(inspector.IsEntity(typeof(Inherited1)), Is.True);
 		}
+
+		[Test]
+		public void SubclassIsAbstract()
+		{
+			//NH-3527
+			var modelMapper = new ModelMapper();
+			modelMapper.Class<MyClass>(c => { });
+			modelMapper.Subclass<Inherited1>(c =>
+			{
+				c.Abstract(true);
+				c.Extends(typeof(MyClass));
+			});
+
+			var mappings = modelMapper.CompileMappingForAllExplicitlyAddedEntities();
+
+			Assert.IsTrue(mappings.SubClasses[0].@abstract);
+			Assert.IsTrue(mappings.SubClasses[0].extends == typeof(MyClass).FullName);
+		}
 	}
 }

src/NHibernate.Test/MappingByCode/ExplicitlyDeclaredModelTests/UnionSubclassMappingStrategyTests.cs

@@ -81,7 +81,7 @@ public void WhenRegisteredAsUnionSubclassThenIsEntity()
 		}
 
 		[Test]
-		public void SubclassIsAbstract()
+		public void UnionSubclassIsAbstract()
 		{
 			//NH-3527
 			var modelMapper = new ModelMapper();

src/NHibernate/Mapping/ByCode/IJoinedSubclassMapper.cs

@@ -10,13 +10,16 @@ public interface IJoinedSubclassAttributesMapper : IEntityAttributesMapper, IEnt
 		void Key(Action<IKeyMapper> keyMapping);
 		void Extends(System.Type baseType);
 		void SchemaAction(SchemaAction action);
-        void Filter(string filterName, Action<IFilterMapper> filterMapping);
+		void Filter(string filterName, Action<IFilterMapper> filterMapping);
+		void Abstract(bool isAbstract);
 	}
 
 	public interface IJoinedSubclassMapper : IJoinedSubclassAttributesMapper, IPropertyContainerMapper {}
 
 	public interface IJoinedSubclassAttributesMapper<TEntity> : IEntityAttributesMapper, IEntitySqlsMapper where TEntity : class
 	{
+		void Abstract(bool isAbstract);
+		void Extends(System.Type baseType);
 		void Table(string tableName);
 		void Catalog(string catalogName);
 		void Schema(string schemaName);

src/NHibernate/Mapping/ByCode/ISubclassMapper.cs

@@ -7,6 +7,7 @@ public interface ISubclassAttributesMapper : IEntityAttributesMapper, IEntitySql
 		void DiscriminatorValue(object value);
 		void Extends(System.Type baseType);
 		void Filter(string filterName, Action<IFilterMapper> filterMapping);
+		void Abstract(bool isAbstract);
 	}
 
 	public interface ISubclassMapper : ISubclassAttributesMapper, IPropertyContainerMapper
@@ -18,6 +19,8 @@ public interface ISubclassAttributesMapper<TEntity> : IEntityAttributesMapper, I
 	{
 		void DiscriminatorValue(object value);
 		void Filter(string filterName, Action<IFilterMapper> filterMapping);
+		void Extends(System.Type baseType);
+		void Abstract(bool isAbstract);
 	}
 
 	public interface ISubclassMapper<TEntity> : ISubclassAttributesMapper<TEntity>, IPropertyContainerMapper<TEntity> where TEntity : class

src/NHibernate/Mapping/ByCode/Impl/CustomizersImpl/JoinedSubclassCustomizer.cs

@@ -111,6 +111,15 @@ public void Subselect(string sql)
 		#endregion
 
 		#region Implementation of IJoinedSubclassAttributesMapper<TEntity>
+		public void Extends(System.Type baseType)
+		{
+			CustomizersHolder.AddCustomizer(typeof(TEntity), (IJoinedSubclassAttributesMapper m) => m.Extends(baseType));
+		}
+
+		public void Abstract(bool isAbstract)
+		{
+			CustomizersHolder.AddCustomizer(typeof(TEntity), (IJoinedSubclassAttributesMapper m) => m.Abstract(isAbstract));
+		}
 
 		public void Table(string tableName)
 		{

src/NHibernate/Mapping/ByCode/Impl/CustomizersImpl/SubclassCustomizer.cs

@@ -22,6 +22,15 @@ public SubclassCustomizer(IModelExplicitDeclarationsHolder explicitDeclarationsH
 		}
 
 		#region ISubclassMapper<TEntity> Members
+		public void Extends(System.Type baseType)
+		{
+			CustomizersHolder.AddCustomizer(typeof(TEntity), (ISubclassMapper m) => m.Extends(baseType));
+		}
+
+		public void Abstract(bool isAbstract)
+		{
+			CustomizersHolder.AddCustomizer(typeof(TEntity), (ISubclassMapper m) => m.Abstract(isAbstract));
+		}
 
 		public void DiscriminatorValue(object value)
 		{

src/NHibernate/Mapping/ByCode/Impl/JoinedSubclassMapper.cs

@@ -149,6 +149,11 @@ public void Subselect(string sql)
 		#endregion
 
 		#region Implementation of IJoinedSubclassAttributesMapper
+		public void Abstract(bool isAbstract)
+		{
+			classMapping.@abstract = isAbstract;
+			classMapping.abstractSpecified = true;
+		}
 
 		public void Table(string tableName)
 		{

src/NHibernate/Mapping/ByCode/Impl/SubclassMapper.cs

@@ -39,6 +39,11 @@ public Dictionary<string, IJoinMapper> JoinMappers
 		}
 
 		#region ISubclassMapper Members
+		public void Abstract(bool isAbstract)
+		{
+			classMapping.@abstract = isAbstract;
+			classMapping.abstractSpecified = true;
+		}
 
 		public void DiscriminatorValue(object value)
 		{