Optimize ToArray conversions

Author: bahusoid

src/NHibernate/Async/Cache/NonstrictReadWriteCache.cs

@@ -50,7 +50,7 @@ public async Task<object[]> GetManyAsync(CacheKey[] keys, long timestamp, Cancel
 			{
 				log.Debug("Cache lookup: {0}", string.Join(",", keys.AsEnumerable()));
 			}
-			var results = await (_cache.GetManyAsync(keys.Select(o => (object) o).ToArray(), cancellationToken)).ConfigureAwait(false);
+			var results = await (_cache.GetManyAsync(keys, cancellationToken)).ConfigureAwait(false);
 			if (!log.IsDebugEnabled())
 			{
 				return results;

src/NHibernate/Async/Cache/ReadOnlyCache.cs

@@ -39,7 +39,7 @@ public async Task<object[]> GetManyAsync(CacheKey[] keys, long timestamp, Cancel
 			{
 				log.Debug("Cache lookup: {0}", string.Join(",", keys.AsEnumerable()));
 			}
-			var results = await (_cache.GetManyAsync(keys.Select(o => (object) o).ToArray(), cancellationToken)).ConfigureAwait(false);
+			var results = await (_cache.GetManyAsync(keys, cancellationToken)).ConfigureAwait(false);
 			if (!log.IsDebugEnabled())
 			{
 				return results;
@@ -95,7 +95,7 @@ public async Task<bool[]> PutManyAsync(
 			var skipKeyIndexes = new HashSet<int>();
 			if (checkKeys.Any())
 			{
-				var objects = await (_cache.GetManyAsync(checkKeys.Select(o => (object) o).ToArray(), cancellationToken)).ConfigureAwait(false);
+				var objects = await (_cache.GetManyAsync(checkKeys.ToArray(), cancellationToken)).ConfigureAwait(false);
 				for (var i = 0; i < objects.Length; i++)
 				{
 					if (objects[i] != null)

src/NHibernate/Async/Cache/ReadWriteCache.cs

@@ -99,7 +99,7 @@ public async Task<object[]> GetManyAsync(CacheKey[] keys, long timestamp, Cancel
 			var result = new object[keys.Length];
 			using (await _lockObjectAsync.LockAsync())
 			{
-				var lockables = await (_cache.GetManyAsync(keys.Select(o => (object) o).ToArray(), cancellationToken)).ConfigureAwait(false);
+				var lockables = await (_cache.GetManyAsync(keys, cancellationToken)).ConfigureAwait(false);
 				for (var i = 0; i < lockables.Length; i++)
 				{
 					var lockable = (ILockable) lockables[i];
@@ -185,12 +185,12 @@ public async Task<bool[]> PutManyAsync(
 				{
 					log.Debug("Caching: {0}", string.Join(",", keys.AsEnumerable()));
 				}
-				var keysArr = keys.Cast<object>().ToArray();
-				var lockValue = await (_cache.LockManyAsync(keysArr, cancellationToken)).ConfigureAwait(false);
+
+				var lockValue = await (_cache.LockManyAsync(keys, cancellationToken)).ConfigureAwait(false);
 				try
 				{
 					var putBatch = new Dictionary<object, object>();
-					var lockables = await (_cache.GetManyAsync(keysArr, cancellationToken)).ConfigureAwait(false);
+					var lockables = await (_cache.GetManyAsync(keys, cancellationToken)).ConfigureAwait(false);
 					for (var i = 0; i < keys.Length; i++)
 					{
 						var key = keys[i];
@@ -231,7 +231,7 @@ public async Task<bool[]> PutManyAsync(
 				}
 				finally
 				{
-					await (_cache.UnlockManyAsync(keysArr, lockValue, cancellationToken)).ConfigureAwait(false);
+					await (_cache.UnlockManyAsync(keys, lockValue, cancellationToken)).ConfigureAwait(false);
 				}
 			}
 			return result;

src/NHibernate/Async/Collection/Generic/PersistentGenericIdentifierBag.cs

@@ -22,6 +22,7 @@
 using NHibernate.Loader;
 using NHibernate.Persister.Collection;
 using NHibernate.Type;
+using NHibernate.Util;
 
 namespace NHibernate.Collection.Generic
 {
@@ -164,7 +165,7 @@ public override Task<ICollection> GetOrphansAsync(object snapshot, string entity
 			try
 			{
 				var sn = (ISet<SnapshotElement>)GetSnapshot();
-				return GetOrphansAsync(sn.Select(x => x.Value).ToArray(), (ICollection) _values, entityName, Session, cancellationToken);
+				return GetOrphansAsync(sn.ToArray(x => x.Value), (ICollection) _values, entityName, Session, cancellationToken);
 			}
 			catch (Exception ex)
 			{

src/NHibernate/Async/Id/IPostInsertIdentityPersister.cs

@@ -17,6 +17,7 @@
 using NHibernate.Persister.Entity;
 using NHibernate.SqlCommand;
 using NHibernate.Type;
+using NHibernate.Util;
 
 namespace NHibernate.Id
 {

src/NHibernate/Async/Id/SelectGenerator.cs

@@ -18,6 +18,7 @@
 using NHibernate.SqlCommand;
 using NHibernate.SqlTypes;
 using NHibernate.Type;
+using NHibernate.Util;
 
 namespace NHibernate.Id
 {

src/NHibernate/Async/Persister/Entity/AbstractEntityPersister.cs

@@ -566,7 +566,7 @@ public async Task BindSelectByUniqueKeyAsync(
 		{
 			cancellationToken.ThrowIfCancellationRequested();
 			var propertyNames = GetUniqueKeyPropertyNames(suppliedPropertyNames);
-			var parameterTypes = propertyNames.Select(GetPropertyType).ToArray();
+			var parameterTypes = propertyNames.ToArray(p => GetPropertyType(p));
 			var entity = binder.Entity;
 			for (var i = 0; i < propertyNames.Length; i++)
 			{

src/NHibernate/Async/Type/CompositeCustomType.cs

@@ -17,6 +17,7 @@
 using NHibernate.SqlTypes;
 using NHibernate.UserTypes;
 using System.Collections.Generic;
+using NHibernate.Util;
 
 namespace NHibernate.Type
 {

src/NHibernate/Bytecode/Lightweight/AccessOptimizer.cs

@@ -2,6 +2,7 @@
 using System.Linq;
 using System.Security;
 using NHibernate.Properties;
+using NHibernate.Util;
 
 namespace NHibernate.Bytecode.Lightweight
 {
@@ -26,8 +27,8 @@ public AccessOptimizer(
 			: this(
 				getDelegate,
 				setDelegate,
-				getters.Select(o => (GetPropertyValueInvoker) o.Get).ToArray(),
-				setters.Select(o => (SetPropertyValueInvoker) o.Set).ToArray(),
+				getters.ToArray(o => (GetPropertyValueInvoker) o.Get),
+				setters.ToArray(o => (SetPropertyValueInvoker) o.Set),
 				null,
 				null)
 		{

src/NHibernate/Cache/NonstrictReadWriteCache.cs

@@ -71,7 +71,7 @@ public object[] GetMany(CacheKey[] keys, long timestamp)
 			{
 				log.Debug("Cache lookup: {0}", string.Join(",", keys.AsEnumerable()));
 			}
-			var results = _cache.GetMany(keys.Select(o => (object) o).ToArray());
+			var results = _cache.GetMany(keys);
 			if (!log.IsDebugEnabled())
 			{
 				return results;