Revert "Merge pull request #251 from ggeurts/NH3594-Mssql2012Dialect"

This reverts commit 8531daf, reversing
changes made to 8ddb412.

Merged caused 30 test failures.

Author: oskarb

src/NHibernate.Test/Linq/MethodCallTests.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Linq;
 using NHibernate.DomainModel.Northwind.Entities;
-using NHibernate.Hql.Ast.ANTLR;
 using NUnit.Framework;
 
 namespace NHibernate.Test.Linq
@@ -35,7 +34,6 @@ public void CanExecuteCountWithOrderByArguments()
 		public void CanSelectPropertiesIntoObjectArray()
 		{
 			var result = db.Users
-				.Where(u => u.Name == "ayende")
 				.Select(u => new object[] {u.Id, u.Name, u.InvalidLoginAttempts})
 				.First();
 
@@ -48,8 +46,7 @@ public void CanSelectPropertiesIntoObjectArray()
 		public void CanSelectComponentsIntoObjectArray()
 		{
 			var result = db.Users
-				.Where(u => u.Component.Property1 == "test1")
-				.Select(u => new object[] { u.Component, u.Component.OtherComponent })
+				.Select(u => new object[] {u.Component, u.Component.OtherComponent})
 				.First();
 
 			Assert.That(result.Length, Is.EqualTo(2));
@@ -84,8 +81,7 @@ public void CanSelectConstantsIntoObjectArray()
 			const string name = "Julian";
 
 			var result = db.Users
-				.OrderBy(u => u.Id)
-				.Select(u => new object[] { u.Id, pi, name, DateTime.MinValue })
+				.Select(u => new object[] {u.Id, pi, name, DateTime.MinValue})
 				.First();
 
 			Assert.That(result.Length, Is.EqualTo(4));
@@ -98,7 +94,6 @@ public void CanSelectConstantsIntoObjectArray()
 		public void CanSelectPropertiesFromAssociationsIntoObjectArray()
 		{
 			var result = db.Users
-				.OrderBy(u => u.Id)
 				.Select(u => new object[] {u.Id, u.Role.Name, u.Role.Entity.Output})
 				.First();
 
@@ -110,10 +105,8 @@ public void CanSelectPropertiesFromAssociationsIntoObjectArray()
 		[Test, Description("NH-2744")]
 		public void CanSelectPropertiesIntoNestedObjectArrays()
 		{
-			var result = db.Users
-				.OrderBy(u => u.Id)
-				.Select(u => new object[] { "Root", new object[] { "Sub1", u.Name, new object[] { "Sub2", u.Name } } })
-				.First();
+			var query = db.Users.Select(u => new object[] {"Root", new object[] {"Sub1", u.Name, new object[] {"Sub2", u.Name}}});
+			var result = query.First();
 
 			Assert.That(result.Length, Is.EqualTo(2));
 			Assert.That(result[0], Is.EqualTo("Root"));

src/NHibernate.Test/NHSpecificTest/NH2214/Fixture.cs

@@ -79,7 +79,7 @@ public void PagedQueryWithDistinctAndOrderingByNonProjectedColumn()
 
 				var query = criteria.GetExecutableCriteria(session);
 
-				Assert.Catch<HibernateException>(() => query.List());
+				Assert.Throws<HibernateException>(() => query.List());
 			}
 		}
 

src/NHibernate/Dialect/MsSql2005DialectQueryPager.cs

@@ -107,7 +107,7 @@ private static void BuildFromClauseForPagingQuery(MsSqlSelectParser sqlQuery, Sq
 
 			if (orderIndex == 0)
 			{
-				result.Add("1");	// order by first column in select clause
+				result.Add("CURRENT_TIMESTAMP");
 			}
 
 			result.Add(") as __hibernate_sort_row ")
@@ -134,7 +134,7 @@ private static void BuildFromClauseForPagingDistinctQuery(MsSqlSelectParser sqlQ
 			}
 			if (orderIndex == 0)
 			{
-				result.Add("1");	// order by first column in select
+				result.Add("CURRENT_TIMESTAMP");
 			}
 
 			result.Add(") as __hibernate_sort_row  FROM (")

src/NHibernate/Dialect/MsSql2012Dialect.cs

@@ -64,7 +64,7 @@ public override SqlString GetLimitString(SqlString querySqlString, SqlString off
 			var result = new SqlStringBuilder(querySqlString);
 			if (!tokenEnum.TryParseUntil("order"))
 			{
-				result.Add(" ORDER BY 1");	// Order by first column in select clause
+				result.Add(" ORDER BY CURRENT_TIMESTAMP");
 			}
 
 			result.Add(" OFFSET ");