Move proxy check before interceptor

Author: bahusoid

src/NHibernate/Async/Engine/ForeignKeys.cs

@@ -171,37 +171,25 @@ public static async Task<bool> IsNotTransientSlowAsync(string entityName, object
 		/// <remarks>
 		/// Don't hit the database to make the determination, instead return null; 
 		/// </remarks>
-		public static Task<bool?> IsTransientFastAsync(string entityName, object entity, ISessionImplementor session, CancellationToken cancellationToken)
+		public static async Task<bool?> IsTransientFastAsync(string entityName, object entity, ISessionImplementor session, CancellationToken cancellationToken)
 		{
-			if (cancellationToken.IsCancellationRequested)
+			cancellationToken.ThrowIfCancellationRequested();
+			if (Equals(Intercept.LazyPropertyInitializer.UnfetchedProperty, entity))
 			{
-				return Task.FromCanceled<bool?>(cancellationToken);
+				// an unfetched association can only point to
+				// an entity that already exists in the db
+				return false;
 			}
-			try
-			{
-				if (Equals(Intercept.LazyPropertyInitializer.UnfetchedProperty, entity))
-				{
-					// an unfetched association can only point to
-					// an entity that already exists in the db
-					return Task.FromResult<bool?>(false);
-				}
-
-				// let the interceptor inspect the instance to decide
-				if (session.Interceptor.IsTransient(entity) == true)
-					return Task.FromResult<bool?>(true);
 
-				if (entity is INHibernateProxy proxy && proxy.HibernateLazyInitializer.IsUninitialized)
-				{
-					return Task.FromResult<bool?>(false);
-				}
-
-				// let the persister inspect the instance to decide	
-				return session.GetEntityPersister(entityName, entity).IsTransientAsync(entity, session, cancellationToken);
-			}
-			catch (System.Exception ex)
+			if (entity is INHibernateProxy proxy && proxy.HibernateLazyInitializer.IsUninitialized)
 			{
-				return Task.FromException<bool?>(ex);
+				return false;
 			}
+
+			// let the interceptor inspect the instance to decide
+			// let the persister inspect the instance to decide
+			return session.Interceptor.IsTransient(entity) ??
+			       await (session.GetEntityPersister(entityName, entity).IsTransientAsync(entity, session, cancellationToken)).ConfigureAwait(false);
 		}
 
 		/// <summary> 

src/NHibernate/Engine/ForeignKeys.cs

@@ -178,17 +178,15 @@ public static bool IsNotTransientSlow(string entityName, object entity, ISession
 				return false;
 			}
 
-			// let the interceptor inspect the instance to decide
-			if (session.Interceptor.IsTransient(entity) == true)
-				return true;
-
 			if (entity is INHibernateProxy proxy && proxy.HibernateLazyInitializer.IsUninitialized)
 			{
 				return false;
 			}
 
-			// let the persister inspect the instance to decide	
-			return session.GetEntityPersister(entityName, entity).IsTransient(entity, session);
+			// let the interceptor inspect the instance to decide
+			// let the persister inspect the instance to decide
+			return session.Interceptor.IsTransient(entity) ??
+			       session.GetEntityPersister(entityName, entity).IsTransient(entity, session);
 		}
 
 		/// <summary>