Use collection types for private members

Author: bahusoid

src/NHibernate/AdoNet/AbstractBatcher.cs

@@ -37,7 +37,7 @@ public abstract partial class AbstractBatcher : IBatcher
 		private SqlType[] _batchCommandParameterTypes;
 		private readonly HashSet<DbCommand> _commandsToClose = new HashSet<DbCommand>();
 		private readonly HashSet<DbDataReader> _readersToClose = new HashSet<DbDataReader>();
-		private readonly IDictionary<DbDataReader, Stopwatch> _readersDuration = new Dictionary<DbDataReader, Stopwatch>();
+		private readonly Dictionary<DbDataReader, Stopwatch> _readersDuration = new Dictionary<DbDataReader, Stopwatch>();
 		private DbCommand _lastQuery;
 		private bool _releasing;
 

src/NHibernate/AdoNet/HanaBatchingBatcher.cs

@@ -17,7 +17,7 @@ public partial class HanaBatchingBatcher : AbstractBatcher
 		private int _countOfCommands;
 		private int _totalExpectedRowsAffected;
 		private DbCommand _currentBatch;
-		private readonly IList<DbCommand> _currentBatchCommands = new List<DbCommand>();
+		private readonly List<DbCommand> _currentBatchCommands = new List<DbCommand>();
 		private StringBuilder _currentBatchCommandsLog;
 
 		public HanaBatchingBatcher(ConnectionManager connectionManager, IInterceptor interceptor)

src/NHibernate/AdoNet/OracleDataClientBatchingBatcher.cs

@@ -17,8 +17,8 @@ public partial class OracleDataClientBatchingBatcher : AbstractBatcher
 		private int _countOfCommands;
 		private int _totalExpectedRowsAffected;
 		private DbCommand _currentBatch;
-		private IDictionary<string, List<object>> _parameterValueListHashTable;
-		private IDictionary<string, bool> _parameterIsAllNullsHashTable;
+		private Dictionary<string, List<object>> _parameterValueListHashTable;
+		private Dictionary<string, bool> _parameterIsAllNullsHashTable;
 		private StringBuilder _currentBatchCommandsLog;
 
 		public OracleDataClientBatchingBatcher(ConnectionManager connectionManager, IInterceptor interceptor)

src/NHibernate/Async/Collection/Generic/PersistentGenericSet.cs

@@ -169,4 +169,4 @@ public override Task<bool> NeedsUpdatingAsync(object entry, int i, IType elemTyp
 			}
 		}
 	}
-}
+}

src/NHibernate/Cfg/Configuration.cs

@@ -818,7 +818,7 @@ public Configuration AddAssembly(Assembly assembly)
 			return this;
 		}
 
-		private static IList<string> GetAllHbmXmlResourceNames(Assembly assembly)
+		private static List<string> GetAllHbmXmlResourceNames(Assembly assembly)
 		{
 			var result = new List<string>();
 

src/NHibernate/Cfg/ConfigurationSchema/EventConfiguration.cs

@@ -49,7 +49,7 @@ public ListenerType Type
 			get { return type; }
 		}
 
-		private IList<ListenerConfiguration> listeners = new List<ListenerConfiguration>();
+		private List<ListenerConfiguration> listeners = new List<ListenerConfiguration>();
 		/// <summary>
 		/// Listeners for this event.
 		/// </summary>

src/NHibernate/Cfg/MappingSchema/HbmDatabaseObject.cs

@@ -17,7 +17,7 @@ public HbmDefinition FindDefinition()
 
 		public IList<string> FindDialectScopeNames()
 		{
-			IList<string> dialectScopeNames = new List<string>();
+			var dialectScopeNames = new List<string>();
 
 			if (dialectscope != null)
 				foreach (HbmDialectScope dialectScopeSchema in dialectscope)
@@ -37,4 +37,4 @@ public bool HasDefinition()
 			return FindDefinition() != null;
 		}
 	}
-}
+}

src/NHibernate/Cfg/MappingsQueue.cs

@@ -11,7 +11,7 @@ namespace NHibernate.Cfg
 	public class MappingsQueue
 	{
 		private readonly Queue availableEntries = new Queue();
-		private readonly ISet<string> processedClassNames = new HashSet<string>();
+		private readonly HashSet<string> processedClassNames = new HashSet<string>();
 
 		private readonly List<MappingsQueueEntry> unavailableEntries = new List<MappingsQueueEntry>();
 
@@ -109,4 +109,4 @@ private static string FormatExceptionMessage(IEnumerable<MappingsQueueEntry> res
 			return message.ToString();
 		}
 	}
-}
+}

src/NHibernate/Cfg/SessionFactoryConfigurationBase.cs

@@ -6,12 +6,12 @@ namespace NHibernate.Cfg
 	public class SessionFactoryConfigurationBase : ISessionFactoryConfiguration
 	{
 		private string name = string.Empty;
-		private readonly IDictionary<string, string> properties = new Dictionary<string, string>();
-		private readonly IList<MappingConfiguration> mappings = new List<MappingConfiguration>();
-		private readonly IList<ClassCacheConfiguration> classesCache= new List<ClassCacheConfiguration>();
-		private readonly IList<CollectionCacheConfiguration> collectionsCache= new List<CollectionCacheConfiguration>();
-		private readonly IList<EventConfiguration> events= new List<EventConfiguration>();
-		private readonly IList<ListenerConfiguration> listeners= new List<ListenerConfiguration>();
+		private readonly Dictionary<string, string> properties = new Dictionary<string, string>();
+		private readonly List<MappingConfiguration> mappings = new List<MappingConfiguration>();
+		private readonly List<ClassCacheConfiguration> classesCache= new List<ClassCacheConfiguration>();
+		private readonly List<CollectionCacheConfiguration> collectionsCache= new List<CollectionCacheConfiguration>();
+		private readonly List<EventConfiguration> events= new List<EventConfiguration>();
+		private readonly List<ListenerConfiguration> listeners= new List<ListenerConfiguration>();
 
 		/// <summary>
 		/// The session factory name.
@@ -70,4 +70,4 @@ public IList<ListenerConfiguration> Listeners
 			get { return listeners; }
 		}
 	}
-}
+}

src/NHibernate/Cfg/XmlHbmBinding/NamedSQLQueryBinder.cs

@@ -33,8 +33,8 @@ public void AddSqlQuery(HbmSqlQuery querySchema)
 												? querySchema.cachemode.ToCacheMode()
 												: null;
 
-					IDictionary<string,string> parameterTypes = new LinkedHashMap<string,string>();
-					IList<string> synchronizedTables = GetSynchronizedTables(querySchema);
+					var parameterTypes = new LinkedHashMap<string,string>();
+					var synchronizedTables = GetSynchronizedTables(querySchema);
 
 					NamedSQLQueryDefinition namedQuery;
 
@@ -58,9 +58,9 @@ public void AddSqlQuery(HbmSqlQuery querySchema)
 				});
 		}
 
-		private static IList<string> GetSynchronizedTables(HbmSqlQuery querySchema)
+		private static List<string> GetSynchronizedTables(HbmSqlQuery querySchema)
 		{
-			IList<string> synchronizedTables = new List<string>();
+			var synchronizedTables = new List<string>();
 
 			foreach (object item in querySchema.Items ?? Array.Empty<object>())
 			{