NH-3807 - Replace uses of ToShortTimeString, ToShortDateString, Comparer.DefaultInvariant, and CreateSpecificCulture.

These have been removed from CoreClr.
Use new CultureInfo(string) instead of CultureInfo.CreateSpecificCulture(string)

Author: ngbrown

src/NHibernate/Type/ByteType.cs

@@ -78,12 +78,12 @@ public virtual object Seed(ISessionImplementor session)
 
 		public IComparer Comparator
 		{
-			get { return Comparer.DefaultInvariant; }
+			get { return System.Collections.Generic.Comparer<byte>.Default; }
 		}
 
 		public override object DefaultValue
 		{
 			get { return ZERO; }
 		}
 	}
-}
+}

src/NHibernate/Type/CultureInfoType.cs

@@ -80,7 +80,14 @@ public override string ToString(object value)
 		/// <returns></returns>
 		public override object FromStringValue(string xml)
 		{
-			return CultureInfo.CreateSpecificCulture(xml);
+			return CreateSpecificCulture(xml);
+		}
+
+		private static CultureInfo CreateSpecificCulture(string name)
+		{
+			var culture = new CultureInfo(name);
+
+			return !culture.IsNeutralCulture ? culture : CultureInfo.InvariantCulture;
 		}
 
 		/// <summary></summary>
@@ -100,4 +107,4 @@ public string ObjectToSQLString(object value, Dialect.Dialect dialect)
 			return ((ILiteralType) NHibernateUtil.String).ObjectToSQLString(value.ToString(), dialect);
 		}
 	}
-}
+}

src/NHibernate/Type/DateType.cs

@@ -96,7 +96,7 @@ public override int GetHashCode(object x, EntityMode entityMode)
 
 		public override string ToString(object val)
 		{
-			return ((DateTime) val).ToShortDateString();
+			return ((DateTime) val).ToString("d");
 		}
 
 		public override object FromStringValue(string xml)
@@ -121,7 +121,7 @@ public override object DefaultValue
 
 		public override string ObjectToSQLString(object value, Dialect.Dialect dialect)
 		{
-			return "\'" + ((DateTime)value).ToShortDateString() + "\'";
+			return "\'" + ((DateTime)value).ToString("d") + "\'";
 		}
 
 		public void SetParameterValues(IDictionary<string, string> parameters)
@@ -137,4 +137,4 @@ public void SetParameterValues(IDictionary<string, string> parameters)
 			}
 		}
 	}
-}
+}

src/NHibernate/Type/TimeType.cs

@@ -131,7 +131,7 @@ public override object DefaultValue
 
 		public override string ObjectToSQLString(object value, Dialect.Dialect dialect)
 		{
-			return "'" + ((DateTime)value).ToShortTimeString() + "'";
+			return "'" + ((DateTime)value).ToString("t") + "'";
 		}
 	}
 }

src/NHibernate/Type/TimestampType.cs

@@ -101,7 +101,7 @@ public virtual object Seed(ISessionImplementor session)
 
 		public IComparer Comparator
 		{
-			get { return Comparer.DefaultInvariant; }
+			get { return System.Collections.Generic.Comparer<DateTime>.Default; }
 		}
 
 		#endregion
@@ -126,4 +126,4 @@ public override string ObjectToSQLString(object value, Dialect.Dialect dialect)
 			return '\'' + value.ToString() + '\'';
 		}
 	}
-}
+}