Fix deepsource concerns

Excepted those unrelated to the change and most of those in the tests.

Author: fredericDelaporte

src/NHibernate.Test/Async/Linq/DateTimeTests.cs

@@ -111,6 +111,7 @@ private void AssertDateTimeOffsetSupported()
 			using var session = OpenSession();
 			using var trans = session.BeginTransaction();
 			var entity1 = await (session.GetAsync<DateTimeTestsClass>(_referenceEntities[0].Id, cancellationToken));
+			await (trans.CommitAsync(cancellationToken));
 			if (entity1.DateTimeValueWithScale != entity1.DateTimeValue + FractionalSecondsAdded)
 			{
 				Assert.Ignore("Current setup doesn't support DateTime with scale (2)");

src/NHibernate.Test/Linq/DateTimeTests.cs

@@ -99,6 +99,7 @@ private void AssertDateTimeWithFractionalSecondsSupported()
 			using var session = OpenSession();
 			using var trans = session.BeginTransaction();
 			var entity1 = session.Get<DateTimeTestsClass>(_referenceEntities[0].Id);
+			trans.Commit();
 			if (entity1.DateTimeValueWithScale != entity1.DateTimeValue + FractionalSecondsAdded)
 			{
 				Assert.Ignore("Current setup doesn't support DateTime with scale (2)");

src/NHibernate/Dialect/Function/SQLFunctionRegistry.cs

@@ -7,8 +7,8 @@ public class SQLFunctionRegistry
 	{
 		private readonly Dialect dialect;
 		private readonly IDictionary<string, ISQLFunction> userFunctions;
-		//Temporary alias support
-		private static Dictionary<string, string> _functionAliases = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase) { { "secondtruncated", "second" } };
+		// Temporary alias support
+		private readonly static Dictionary<string, string> _functionAliases = new(StringComparer.OrdinalIgnoreCase) { { "secondtruncated", "second" } };
 
 		public SQLFunctionRegistry(Dialect dialect, IDictionary<string, ISQLFunction> userFunctions)
 		{
@@ -22,10 +22,10 @@ public SQLFunctionRegistry(Dialect dialect, IDictionary<string, ISQLFunction> us
 		/// </summary>
 		public ISQLFunction FindSQLFunction(string functionName)
 		{
-			if (!userFunctions.TryGetValue(functionName, out ISQLFunction result) && !dialect.Functions.TryGetValue(functionName, out result))
+			if (!userFunctions.TryGetValue(functionName, out ISQLFunction result) && !dialect.Functions.TryGetValue(functionName, out result)
+				&& _functionAliases.TryGetValue(functionName, out var sqlFunction) && !_functionAliases.ContainsKey(sqlFunction))
 			{
-				if (_functionAliases.TryGetValue(functionName, out var sqlFunction) && !_functionAliases.ContainsKey(sqlFunction))
-					return FindSQLFunction(sqlFunction);
+				return FindSQLFunction(sqlFunction);
 			}
 			return result;
 		}