Clean up the test case

Author: fredericDelaporte

src/NHibernate.Test/NHSpecificTest/GH3643/Entity.cs

@@ -1,6 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
+using System.Collections.Generic;
 
 // ReSharper disable CollectionNeverUpdated.Local
 // ReSharper disable UnassignedGetOnlyAutoProperty
@@ -9,14 +7,14 @@ namespace NHibernate.Test.NHSpecificTest.GH3643
 {
 	class Entity
 	{
-		private readonly ICollection<ChildEntity> _children = new List<ChildEntity>();
-		public virtual EntityId Id { get; protected set; }
-		public virtual IEnumerable<ChildEntity> Children => _children.AsEnumerable();
+		private readonly ICollection<ChildEntity> _children = [];
+		public virtual EntityId Id { get; set; }
+		public virtual ICollection<ChildEntity> Children => _children;
 	}
 
 	class ChildEntity
 	{
-		public virtual int Id { get; protected set; }
+		public virtual int Id { get; set; }
 	}
 
 	enum EntityId

src/NHibernate.Test/NHSpecificTest/GH3643/FixtureByCode.cs

@@ -30,6 +30,7 @@ protected override HbmMapping GetMappings()
 						{
 							m.Access(Accessor.Field);
 							m.Key(k => k.Column("EntityId"));
+							m.Cascade(Mapping.ByCode.Cascade.All);
 						},
 						r => r.OneToMany());
 
@@ -60,19 +61,12 @@ protected override void OnSetUp()
 		{
 			using var session = OpenSession();
 			using var transaction = session.BeginTransaction();
-			
-			session.CreateSQLQuery(
-				"INSERT INTO Entity (Id) VALUES (0)"
-			).ExecuteUpdate();
 
-			session.CreateSQLQuery(
-				"INSERT INTO ChildEntity (Id, EntityId) VALUES (0, 0)"
-			).ExecuteUpdate();
+			var entity = new Entity { Id = EntityId.Id1 };
+			entity.Children.Add(new ChildEntity { Id = 0 });
+			entity.Children.Add(new ChildEntity { Id = 1 });
+			session.Save(entity);
 
-			session.CreateSQLQuery(
-				"INSERT INTO ChildEntity (Id, EntityId) VALUES (1, 0)"
-			).ExecuteUpdate();
-			
 			transaction.Commit();
 		}
 
@@ -81,8 +75,8 @@ protected override void OnTearDown()
 			using var session = OpenSession();
 			using var transaction = session.BeginTransaction();
 
-			session.CreateSQLQuery("DELETE FROM ChildEntity").ExecuteUpdate();
-			session.CreateSQLQuery("DELETE FROM Entity").ExecuteUpdate();
+			session.CreateQuery("delete from ChildEntity").ExecuteUpdate();
+			session.CreateQuery("delete from System.Object").ExecuteUpdate();
 
 			transaction.Commit();
 		}
@@ -106,10 +100,10 @@ private Entity LoadEntityWithQueryCache()
 			using var session = OpenSession();
 			using var transaction = session.BeginTransaction();
 			var entity = session
-			          .Query<Entity>()
-			          .FetchMany(x => x.Children)
-			          .WithOptions(opt => opt.SetCacheable(true))
-			          .ToList()[0];
+				.Query<Entity>()
+				.FetchMany(x => x.Children)
+				.WithOptions(opt => opt.SetCacheable(true))
+				.ToList()[0];
 
 			transaction.Commit();
 			return entity;

src/NHibernate.sln.DotSettings

@@ -21,9 +21,6 @@
 	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/PredefinedNamingRules/=PrivateConstants/@EntryIndexedValue">&lt;Policy Inspect="True" Prefix="" Suffix="" Style="aaBb" /&gt;</s:String>
 	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/PredefinedNamingRules/=PrivateInstanceFields/@EntryIndexedValue">&lt;Policy Inspect="True" Prefix="_" Suffix="" Style="aaBb" /&gt;</s:String>
 	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/PredefinedNamingRules/=PrivateStaticReadonly/@EntryIndexedValue">&lt;Policy Inspect="True" Prefix="" Suffix="" Style="AaBb" /&gt;</s:String>
-	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/UserRules/=15b5b1f1_002D457c_002D4ca6_002Db278_002D5615aedc07d3/@EntryIndexedValue">&lt;Policy&gt;&lt;Descriptor Staticness="Static" AccessRightKinds="Private" Description="Static readonly fields (private)"&gt;&lt;ElementKinds&gt;&lt;Kind Name="READONLY_FIELD" /&gt;&lt;/ElementKinds&gt;&lt;/Descriptor&gt;&lt;Policy Inspect="True" WarnAboutPrefixesAndSuffixes="False" Prefix="" Suffix="" Style="AaBb" /&gt;&lt;/Policy&gt;</s:String>
-	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/UserRules/=236f7aa5_002D7b06_002D43ca_002Dbf2a_002D9b31bfcff09a/@EntryIndexedValue">&lt;Policy&gt;&lt;Descriptor Staticness="Any" AccessRightKinds="Private" Description="Constant fields (private)"&gt;&lt;ElementKinds&gt;&lt;Kind Name="CONSTANT_FIELD" /&gt;&lt;/ElementKinds&gt;&lt;/Descriptor&gt;&lt;Policy Inspect="True" WarnAboutPrefixesAndSuffixes="False" Prefix="" Suffix="" Style="aaBb" /&gt;&lt;/Policy&gt;</s:String>
-	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/UserRules/=4a98fdf6_002D7d98_002D4f5a_002Dafeb_002Dea44ad98c70c/@EntryIndexedValue">&lt;Policy&gt;&lt;Descriptor Staticness="Instance" AccessRightKinds="Private" Description="Instance fields (private)"&gt;&lt;ElementKinds&gt;&lt;Kind Name="FIELD" /&gt;&lt;Kind Name="READONLY_FIELD" /&gt;&lt;/ElementKinds&gt;&lt;/Descriptor&gt;&lt;Policy Inspect="True" WarnAboutPrefixesAndSuffixes="False" Prefix="_" Suffix="" Style="aaBb" /&gt;&lt;/Policy&gt;</s:String>
 	<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ECSharpAttributeForSingleLineMethodUpgrade/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ECSharpKeepExistingMigration/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ECSharpPlaceEmbeddedOnSameLineMigration/@EntryIndexedValue">True</s:Boolean>
@@ -32,7 +29,6 @@
 	<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ESettingsUpgrade_002ECSharpPlaceAttributeOnSameLineMigration/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ESettingsUpgrade_002EMigrateBlankLinesAroundFieldToBlankLinesAroundProperty/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ESettingsUpgrade_002EMigrateThisQualifierSettings/@EntryIndexedValue">True</s:Boolean>
-	<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ESettingsUpgrade_002EPredefinedNamingRulesToUserRulesUpgrade/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002EFormat_002ESettingsUpgrade_002EAlignmentTabFillStyleMigration/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/Environment/UnitTesting/SeparateAppDomainPerAssembly/@EntryValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/PatternsAndTemplates/StructuralSearch/Pattern/=0BE95D01E0F2244E97F5FEFAD1EB1A63/@KeyIndexDefined">True</s:Boolean>