Skip to content

Commit a0863a1

Browse files
committed
Fix some CodeFactor issues
1 parent f089c44 commit a0863a1

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

src/NHibernate.Test/Linq/NullComparisonTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,6 @@ public void NullEqualityWithNotNullSubSelect()
332332
Expect(q, Does.Not.Contain("is null").IgnoreCase);
333333
}
334334

335-
336335
[Test]
337336
public void NullEquality()
338337
{

src/NHibernate/Linq/Visitors/NullableExpressionDetector.cs

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,16 @@ public void SearchForNotNullMemberChecks(BinaryExpression expression)
4141
// Example: o.Status != null && o.Status != "New"
4242
// Example: (o.Status != null && o.OldStatus != null) && (o.Status != o.OldStatus)
4343
// Example: (o.Status != null && o.OldStatus != null) && (o.Status == o.OldStatus)
44-
if (expression.NodeType != ExpressionType.AndAlso ||
45-
expression.Right.NodeType != ExpressionType.NotEqual &&
46-
expression.Right.NodeType != ExpressionType.Equal ||
47-
expression.Left.NodeType != ExpressionType.AndAlso &&
48-
expression.Left.NodeType != ExpressionType.NotEqual)
44+
if (
45+
expression.NodeType != ExpressionType.AndAlso ||
46+
(
47+
expression.Right.NodeType != ExpressionType.NotEqual &&
48+
expression.Right.NodeType != ExpressionType.Equal
49+
) ||
50+
(
51+
expression.Left.NodeType != ExpressionType.AndAlso &&
52+
expression.Left.NodeType != ExpressionType.NotEqual
53+
))
4954
{
5055
return;
5156
}

0 commit comments

Comments
 (0)