NH-3638: Use real equality instead of hash code for PropertyPath equality. Running the test code in NH-3638 demonstrates that the bug disappears with this change. No unit test committed since reproduction requires relatively complex long-running scenario.

Author: patearl

src/NHibernate/Mapping/ByCode/PropertyPath.cs

@@ -63,7 +63,7 @@ public bool Equals(PropertyPath other)
 			{
 				return true;
 			}
-			return hashCode == other.GetHashCode();
+			return (ReferenceEquals(previousPath, null) && ReferenceEquals(other.previousPath, null) || !ReferenceEquals(previousPath, null) && previousPath.Equals(other.previousPath)) && localMember.Equals(other.localMember);
 		}
 
 		public override int GetHashCode()