NH-3488 - fix dialect dependent failures, fourth round, to be squashed. And reference for a specific Firebird bug justifying an ignore.

Author: fredericDelaporte

src/NHibernate.Test/Hql/Ast/BulkManipulation.cs

@@ -62,6 +62,11 @@ public void SimpleInsert()
 		[Test]
 		public void SimpleInsertFromAggregate()
 		{
+			if (!Dialect.SupportsTemporaryTables)
+			{
+				Assert.Ignore("Cannot perform multi-table inserts using dialect not supporting temp tables.");
+			}
+
 			var data = new TestData(this);
 			data.Prepare();
 

src/NHibernate.Test/NHSpecificTest/NH3488/LinqBulkManipulationFixture.cs

@@ -377,7 +377,7 @@ public void InsertWithSelectListUsingJoins()
 
 				s.Query<Human>().Where(x => x.Mother.Mother != null)
 					.Insert().As(x => new Animal { Description = x.Description, BodyWeight = x.BodyWeight });
-				
+
 				s.Transaction.Commit();
 				s.Close();
 			}
@@ -386,9 +386,10 @@ public void InsertWithSelectListUsingJoins()
 		[Test]
 		public void InsertToComponent()
 		{
-			if(Dialect is FirebirdDialect)
+			if (Dialect is FirebirdDialect)
 			{
-				Assert.Ignore("This test seems to trigger a recursive insert into DB with Firebird.");
+				// https://firebirdsql.org/file/documentation/reference_manuals/fblangref25-en/html/fblangref25-dml-insert.html#fblangref25-dml-insert-select-unstable
+				Assert.Ignore("This test triggers the Firebird \"unstable cursor"\" bug, a recursive insert of inserted rows.");
 			}
 
 			using (var s = OpenSession())