NH-1752 - Cease silently nullifying dates before 1753

Obsolete base date parameterization and set its default value to MinDate

Author: fredericDelaporte

src/NHibernate.Test/Async/FilterTest/DynamicFilterTest.cs

@@ -773,4 +773,4 @@ public void Dispose()
 			}
 		}
 	}
-}
+}

src/NHibernate.Test/Async/TypesTest/DateTypeTest.cs

@@ -0,0 +1,79 @@
+//------------------------------------------------------------------------------
+// <auto-generated>
+//     This code was generated by AsyncGenerator.
+//
+//     Changes to this file may cause incorrect behavior and will be lost if
+//     the code is regenerated.
+// </auto-generated>
+//------------------------------------------------------------------------------
+
+
+using System.Collections.Generic;
+using NHibernate.Dialect;
+using NHibernate.Type;
+using NUnit.Framework;
+using System;
+
+namespace NHibernate.Test.TypesTest
+{
+	using System.Threading.Tasks;
+	using System.Threading;
+
+	[TestFixture]
+	public class DateTypeFixtureAsync : TypeFixtureBase
+	{
+		protected override string TypeName
+		{
+			get { return "Date"; }
+		}
+
+		[Test]
+		public Task ReadWriteNormalAsync()
+		{
+			try
+			{
+				var expected = DateTime.Today;
+
+				return ReadWriteAsync(expected);
+			}
+			catch (Exception ex)
+			{
+				return Task.FromException<object>(ex);
+			}
+		}
+
+		[Test]
+		public Task ReadWriteMinAsync()
+		{
+			try
+			{
+				var expected = Sfi.ConnectionProvider.Driver.MinDate;
+
+				return ReadWriteAsync(expected);
+			}
+			catch (Exception ex)
+			{
+				return Task.FromException<object>(ex);
+			}
+		}
+
+		private async Task ReadWriteAsync(DateTime expected, CancellationToken cancellationToken = default(CancellationToken))
+		{
+			// Add an hour to check it is correctly ignored once read back from db.
+			var basic = new DateClass { DateValue = expected.AddHours(1) };
+			object savedId;
+			using (var s = OpenSession())
+			{
+				savedId = await (s.SaveAsync(basic, cancellationToken)); 
+				await (s.FlushAsync(cancellationToken));
+			}
+			using (var s = OpenSession())
+			{
+				basic = await (s.GetAsync<DateClass>(savedId, cancellationToken));
+				Assert.That(basic.DateValue, Is.EqualTo(expected));
+				await (s.DeleteAsync(basic, cancellationToken));
+				await (s.FlushAsync(cancellationToken));
+			}
+		}
+	}
+}

src/NHibernate.Test/FilterTest/Category.cs

@@ -7,8 +7,8 @@ public class Category
 	{
 		private long id;
 		private String name;
-		private DateTime effectiveStartDate;
-		private DateTime effectiveEndDate;
+		private DateTime? effectiveStartDate;
+		private DateTime? effectiveEndDate;
 		private ISet<Product> products;
 
 		public Category()
@@ -39,13 +39,13 @@ public virtual string Name
 			set { name = value; }
 		}
 
-		public virtual DateTime EffectiveStartDate
+		public virtual DateTime? EffectiveStartDate
 		{
 			get { return effectiveStartDate; }
 			set { effectiveStartDate = value; }
 		}
 
-		public virtual DateTime EffectiveEndDate
+		public virtual DateTime? EffectiveEndDate
 		{
 			get { return effectiveEndDate; }
 			set { effectiveEndDate = value; }
@@ -93,4 +93,4 @@ public override int GetHashCode()
 			return result;
 		}
 	}
-}
+}

src/NHibernate.Test/FilterTest/DynamicFilterTest.cs

@@ -747,4 +747,4 @@ public void Dispose()
 			}
 		}
 	}
-}
+}

src/NHibernate.Test/FilterTest/Order.cs

@@ -7,8 +7,8 @@ public class Order
 	{
 		private long id;
 		private String region;
-		private DateTime placementDate;
-		private DateTime fulfillmentDate;
+		private DateTime? placementDate;
+		private DateTime? fulfillmentDate;
 		private Salesperson salesperson;
 		private String buyer;
 		private IList<LineItem> lineItems = new List<LineItem>();
@@ -25,13 +25,13 @@ public virtual string Region
 			set { region = value; }
 		}
 
-		public virtual DateTime PlacementDate
+		public virtual DateTime? PlacementDate
 		{
 			get { return placementDate; }
 			set { placementDate = value; }
 		}
 
-		public virtual DateTime FulfillmentDate
+		public virtual DateTime? FulfillmentDate
 		{
 			get { return fulfillmentDate; }
 			set { fulfillmentDate = value; }
@@ -70,4 +70,4 @@ public virtual void RemoveLineItem(int sequence)
 			LineItems.RemoveAt(sequence);
 		}
 	}
-}
+}

src/NHibernate.Test/FilterTest/Product.cs

@@ -8,8 +8,8 @@ public class Product
 		private long id;
 		private string name;
 		private int stockNumber; // int for ease of hashCode() impl
-		private DateTime effectiveStartDate;
-		private DateTime effectiveEndDate;
+		private DateTime? effectiveStartDate;
+		private DateTime? effectiveEndDate;
 		private ISet<LineItem> orderLineItems;
 		private ISet<Category> categories;
 
@@ -51,13 +51,13 @@ public virtual int StockNumber
 			set { stockNumber = value; }
 		}
 
-		public virtual DateTime EffectiveStartDate
+		public virtual DateTime? EffectiveStartDate
 		{
 			get { return effectiveStartDate; }
 			set { effectiveStartDate = value; }
 		}
 
-		public virtual DateTime EffectiveEndDate
+		public virtual DateTime? EffectiveEndDate
 		{
 			get { return effectiveEndDate; }
 			set { effectiveEndDate = value; }
@@ -85,4 +85,4 @@ public override bool Equals(object obj)
 			return obj is Product && (((Product) obj).stockNumber == this.stockNumber);
 		}
 	}
-}
+}

src/NHibernate.Test/FilterTest/Salesperson.cs

@@ -8,7 +8,7 @@ public class Salesperson
 		private long id;
 		private String name;
 		private String region;
-		private DateTime hireDate;
+		private DateTime? hireDate;
 		private Department department;
 		private ISet<Order> orders = new HashSet<Order>();
 
@@ -30,7 +30,7 @@ public virtual string Region
 			set { region = value; }
 		}
 
-		public virtual DateTime HireDate
+		public virtual DateTime? HireDate
 		{
 			get { return hireDate; }
 			set { hireDate = value; }
@@ -48,4 +48,4 @@ public virtual ISet<Order> Orders
 			set { orders = value; }
 		}
 	}
-}
+}

src/NHibernate.Test/Hql/Ast/Mammal.cs

@@ -5,18 +5,18 @@ namespace NHibernate.Test.Hql.Ast
 	public class Mammal: Animal
 	{
 		private bool pregnant;
-		private DateTime birthdate;
+		private DateTime? birthdate;
 
 		public virtual bool Pregnant
 		{
 			get { return pregnant; }
 			set { pregnant = value; }
 		}
 
-		public virtual DateTime Birthdate
+		public virtual DateTime? Birthdate
 		{
 			get { return birthdate; }
 			set { birthdate = value; }
 		}
 	}
-}
+}

src/NHibernate.Test/LinqBulkManipulation/Domain/Mammal.cs

@@ -5,18 +5,18 @@ namespace NHibernate.Test.LinqBulkManipulation.Domain
 	public class Mammal: Animal
 	{
 		private bool pregnant;
-		private DateTime birthdate;
+		private DateTime? birthdate;
 
 		public virtual bool Pregnant
 		{
 			get { return pregnant; }
 			set { pregnant = value; }
 		}
 
-		public virtual DateTime Birthdate
+		public virtual DateTime? Birthdate
 		{
 			get { return birthdate; }
 			set { birthdate = value; }
 		}
 	}
-}
+}

src/NHibernate.Test/Stateless/Naturalness.cs

@@ -18,7 +18,7 @@ public class Human : Animal
 	{
 		public virtual string Name { get; set; }
 		public virtual string NickName { get; set; }
-		public virtual DateTime Birthdate { get; set; }
+		public virtual DateTime? Birthdate { get; set; }
 	}
 
 	public class Family<T> where T: Animal
@@ -34,4 +34,4 @@ public virtual ISet<T> Childs
 			set { childs = value; }
 		}
 	}
-}
+}