NH-3619 - Make default value of FlushMode configurable

Author: rjperes

src/NHibernate.Test/App.config

@@ -51,6 +51,8 @@
 			<property name="format_sql">true</property>
 			<property name="show_sql">false</property>
 			<property name="command_timeout">444</property>
+
+			<property name="default_flush_mode">Commit</property>
 
 		</session-factory>
 	</hibernate-configuration>

src/NHibernate.Test/CfgTest/DefaultFlushModeFixture.cs

@@ -0,0 +1,82 @@
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using NHibernate.Cfg;
+using NUnit.Framework;
+
+namespace NHibernate.Test.CfgTest
+{
+	[TestFixture]
+	public class DefaultFlushModeFixture
+	{
+		[Test]
+		public void CanSetDefaultFlushModeThroughXmlConfiguration()
+		{
+			var cfg = new Configuration().Configure();
+
+			using (var sessionFactory = cfg.BuildSessionFactory())
+			{
+				using (var session = sessionFactory.OpenSession())
+				{
+					Assert.AreEqual(session.FlushMode, FlushMode.Commit);
+				}
+			}
+		}
+
+		[Test]
+		public void CanSetDefaultFlushModeThroughStandardConfiguration()
+		{
+			var cfg = new Configuration().Configure();
+			cfg.Properties[Environment.DefaultFlushMode] = FlushMode.Always.ToString();
+
+			using (var sessionFactory = cfg.BuildSessionFactory())
+			{
+				using (var session = sessionFactory.OpenSession())
+				{
+					Assert.AreEqual(session.FlushMode, FlushMode.Always);
+				}
+			}
+
+			cfg.Properties[Environment.DefaultFlushMode] = FlushMode.Commit.ToString();
+
+			using (var sessionFactory = cfg.BuildSessionFactory())
+			{
+				using (var session = sessionFactory.OpenSession())
+				{
+					Assert.AreEqual(session.FlushMode, FlushMode.Commit);
+				}
+			}
+		}
+
+		[Test]
+		public void CanSetDefaultFlushModeThroughLoquaciousConfiguration()
+		{
+			var cfg = new Configuration()
+				.Configure();
+
+			cfg
+				.SessionFactory()
+				.DefaultFlushMode(FlushMode.Always);
+
+			using (var sessionFactory = cfg.BuildSessionFactory())
+			{
+				using (var session = sessionFactory.OpenSession())
+				{
+					Assert.AreEqual(session.FlushMode, FlushMode.Always);
+				}
+			}
+
+			cfg.Configure()
+				.SessionFactory()
+				.DefaultFlushMode(FlushMode.Commit);
+
+			using (var sessionFactory = cfg.BuildSessionFactory())
+			{
+				using (var session = sessionFactory.OpenSession())
+				{
+					Assert.AreEqual(session.FlushMode, FlushMode.Commit);
+				}
+			}
+		}
+	}
+}

src/NHibernate.Test/NHibernate.Test.csproj

@@ -166,6 +166,7 @@
     <Compile Include="CfgTest\ConfigurationSchemaFixture.cs" />
     <Compile Include="CfgTest\ConfigurationSerializationTests.cs" />
     <Compile Include="CfgTest\CustomBytecodeProviderTest.cs" />
+    <Compile Include="CfgTest\DefaultFlushModeFixture.cs" />
     <Compile Include="CfgTest\DefaultNsAssmFixture.cs" />
     <Compile Include="CfgTest\EntityCacheUsageParserFixture.cs" />
     <Compile Include="CfgTest\HbmOrderingFixture.cs" />

src/NHibernate/Cfg/Environment.cs

@@ -90,6 +90,9 @@ public static string Version
 		/// <summary>The EntityMode in which set the Session opened from the SessionFactory.</summary>
 		public const string DefaultEntityMode = "default_entity_mode";
 
+		/// Implementation of NH-3619 - Make default value of FlushMode configurable
+		public const string DefaultFlushMode = "default_flush_mode";
+
 		/// <summary>
 		/// When using an enhanced id generator and pooled optimizers (<see cref="NHibernate.Id.Enhanced.IOptimizer"/>),
 		/// prefer interpreting the database value as the lower (lo) boundary. The default is to interpret it as the high boundary.

src/NHibernate/Cfg/Loquacious/FluentSessionFactoryConfiguration.cs

@@ -47,6 +47,12 @@ public IFluentSessionFactoryConfiguration Using(EntityMode entityMode)
 			return this;
 		}
 
+		public IFluentSessionFactoryConfiguration DefaultFlushMode(FlushMode flushMode)
+		{
+			configuration.SetProperty(Environment.DefaultFlushMode, flushMode.ToString());
+			return this;
+		}
+
 		public IFluentSessionFactoryConfiguration ParsingHqlThrough<TQueryTranslator>()
 			where TQueryTranslator : IQueryTranslatorFactory
 		{

src/NHibernate/Cfg/Loquacious/IFluentSessionFactoryConfiguration.cs

@@ -26,6 +26,8 @@ public interface IFluentSessionFactoryConfiguration
 
 		IFluentSessionFactoryConfiguration GenerateStatistics();
 		IFluentSessionFactoryConfiguration Using(EntityMode entityMode);
+		IFluentSessionFactoryConfiguration DefaultFlushMode(FlushMode flushMode);
+
 		IFluentSessionFactoryConfiguration ParsingHqlThrough<TQueryTranslator>() where TQueryTranslator : IQueryTranslatorFactory;
 		IFluentSessionFactoryConfiguration ParsingLinqThrough<TQueryProvider>() where TQueryProvider : INhQueryProvider;
 

src/NHibernate/Cfg/Settings.cs

@@ -110,6 +110,8 @@ public Settings()
 
 		public bool IsOrderInsertsEnabled { get; internal set; }
 
+		public FlushMode DefaultFlushMode { get; internal set; }
+
 		public EntityMode DefaultEntityMode { get; internal set; }
 
 		public bool IsDataDefinitionImplicitCommit { get; internal set; }

src/NHibernate/Cfg/SettingsFactory.cs

@@ -259,6 +259,11 @@ public Settings BuildSettings(IDictionary<string, string> properties)
 				}
 			}
 
+			//NH-3619
+			FlushMode defaultFlushMode = (FlushMode) Enum.Parse(typeof(FlushMode), PropertiesHelper.GetString(Environment.DefaultFlushMode, properties, FlushMode.Unspecified.ToString()), false);
+			log.Info("Default flush mode: " + defaultFlushMode);
+			settings.DefaultFlushMode = defaultFlushMode;
+
 			EntityMode defaultEntityMode =
 				EntityModeHelper.Parse(PropertiesHelper.GetString(Environment.DefaultEntityMode, properties, "poco"));
 			log.Info("Default entity-mode: " + defaultEntityMode);

src/NHibernate/Impl/SessionFactoryImpl.cs

@@ -497,7 +497,7 @@ public ISession OpenSession(IDbConnection connection, bool flushBeforeCompletion
 			return
 				new SessionImpl(connection, this, true, settings.CacheProvider.NextTimestamp(), interceptor,
 								settings.DefaultEntityMode, flushBeforeCompletionEnabled, autoCloseSessionEnabled,
-								isInterceptorsBeforeTransactionCompletionIgnoreExceptionsEnabled, connectionReleaseMode);
+								isInterceptorsBeforeTransactionCompletionIgnoreExceptionsEnabled, connectionReleaseMode, settings.DefaultFlushMode);
 		}
 
 		public IEntityPersister GetEntityPersister(string entityName)
@@ -1215,7 +1215,8 @@ private SessionImpl OpenSession(IDbConnection connection, bool autoClose, long t
 			SessionImpl session = new SessionImpl(connection, this, autoClose, timestamp, sessionLocalInterceptor ?? interceptor,
 												  settings.DefaultEntityMode, settings.IsFlushBeforeCompletionEnabled,
 												  settings.IsAutoCloseSessionEnabled, isInterceptorsBeforeTransactionCompletionIgnoreExceptionsEnabled,
-												  settings.ConnectionReleaseMode);
+												  settings.ConnectionReleaseMode, settings.DefaultFlushMode);
+
 			if (sessionLocalInterceptor != null)
 			{
 				// NH specific feature

src/NHibernate/Impl/SessionImpl.cs

@@ -215,7 +215,8 @@ internal SessionImpl(
 			bool flushBeforeCompletionEnabled,
 			bool autoCloseSessionEnabled,
 			bool ignoreExceptionBeforeTransactionCompletion,
-			ConnectionReleaseMode connectionReleaseMode)
+			ConnectionReleaseMode connectionReleaseMode,
+			FlushMode defaultFlushMode)
 			: base(factory)
 		{
 			using (new SessionIdLoggingContext(SessionId))
@@ -235,6 +236,7 @@ internal SessionImpl(
 				this.connectionReleaseMode = connectionReleaseMode;
 				this.ignoreExceptionBeforeTransactionCompletion = ignoreExceptionBeforeTransactionCompletion;
 				connectionManager = new ConnectionManager(this, connection, connectionReleaseMode, interceptor);
+				this.flushMode = defaultFlushMode;
 
 				if (factory.Statistics.IsStatisticsEnabled)
 				{