Obsolete IValue SetTypeUsingReflection & associated methods (#3555)

Author: hazzik

src/NHibernate/Cfg/XmlHbmBinding/ClassCompositeIdBinder.cs

@@ -190,7 +190,7 @@ private Property CreateProperty(ToOne value, string propertyName, System.Type pa
 		{
 			if (parentClass != null && value.IsSimpleValue)
 			{
-				value.SetTypeUsingReflection(parentClass.AssemblyQualifiedName, propertyName,
+				value.SetTypeUsingReflection(parentClass, propertyName,
 				                             keyManyToOneSchema.access ?? mappings.DefaultAccess);
 			}
 
@@ -242,7 +242,7 @@ private Property CreateProperty(SimpleValue value, string propertyName, System.T
 		{
 			if (parentClass != null && value.IsSimpleValue)
 			{
-				value.SetTypeUsingReflection(parentClass.AssemblyQualifiedName, propertyName,
+				value.SetTypeUsingReflection(parentClass, propertyName,
 				                             keyPropertySchema.access ?? mappings.DefaultAccess);
 			}
 

src/NHibernate/Cfg/XmlHbmBinding/ClassIdBinder.cs

@@ -45,7 +45,7 @@ private void CreateIdentifierProperty(HbmId idSchema, PersistentClass rootClass,
 			if (idSchema.name != null)
 			{
 				string access = idSchema.access ?? mappings.DefaultAccess;
-				id.SetTypeUsingReflection(rootClass.MappedClass?.AssemblyQualifiedName, idSchema.name, access);
+				id.SetTypeUsingReflection(rootClass.MappedClass, idSchema.name, access);
 
 				var property = new Property(id) { Name = idSchema.name };
 

src/NHibernate/Cfg/XmlHbmBinding/PropertiesBinder.cs

@@ -386,16 +386,35 @@ private void BindCollectionProperty(ICollectionPropertiesMapping collectionMappi
 			property.Cascade = collectionMapping.Cascade ?? mappings.DefaultCascade;
 		}
 
-		private Property CreateProperty(IEntityPropertyMapping propertyMapping, System.Type propertyOwnerType, IValue value, IDictionary<string, MetaAttribute> inheritedMetas)
+		private Property CreateProperty(IEntityPropertyMapping propertyMapping, System.Type propertyOwnerType, SimpleValue value, IDictionary<string, MetaAttribute> inheritedMetas)
 		{
 			var type = propertyOwnerType?.UnwrapIfNullable();
 			if (string.IsNullOrEmpty(propertyMapping.Name))
 				throw new MappingException("A property mapping must define the name attribute [" + type + "]");
 
 			var propertyAccessorName = GetPropertyAccessorName(propertyMapping.Access);
 
-			if (type != null && value.IsSimpleValue)
-				value.SetTypeUsingReflection(type.AssemblyQualifiedName, propertyMapping.Name, propertyAccessorName);
+			if (type != null)
+				value.SetTypeUsingReflection(type, propertyMapping.Name, propertyAccessorName);
+
+			return new Property
+			{
+				Name = propertyMapping.Name,
+				PropertyAccessorName = propertyAccessorName,
+				Value = value,
+				IsLazy = propertyMapping.IsLazyProperty,
+				LazyGroup = propertyMapping.GetLazyGroup(),
+				IsOptimisticLocked = propertyMapping.OptimisticLock,
+				MetaAttributes = GetMetas(propertyMapping, inheritedMetas)
+			};
+		}
+		
+		private Property CreateProperty(IEntityPropertyMapping propertyMapping, System.Type propertyOwnerType, Mapping.Collection value, IDictionary<string, MetaAttribute> inheritedMetas)
+		{
+			if (string.IsNullOrEmpty(propertyMapping.Name))
+				throw new MappingException("A property mapping must define the name attribute [" + propertyOwnerType + "]");
+
+			var propertyAccessorName = GetPropertyAccessorName(propertyMapping.Access);
 
 			return new Property
 			{

src/NHibernate/Mapping/Any.cs

@@ -72,10 +72,16 @@ public void ResetCachedType()
 			_type = GetLazyType();
 		}
 
+		// Since v5.6
+		[Obsolete("This method is not used and will be removed in a future version")]
 		public override void SetTypeUsingReflection(string className, string propertyName, string access)
 		{
 		}
 
+		public override void SetTypeUsingReflection(System.Type propertyOwnerType, string propertyName, string access)
+		{
+		}
+
 		/// <summary>
 		/// Get or set the metatype 
 		/// </summary>

src/NHibernate/Mapping/Collection.cs

@@ -593,6 +593,8 @@ public virtual bool IsAlternateUniqueKey
 			get { return false; }
 		}
 
+		// Since v5.6
+		[Obsolete("This method is not used and will be removed in a future version")]
 		public void SetTypeUsingReflection(string className, string propertyName, string access)
 		{
 		}

src/NHibernate/Mapping/Component.cs

@@ -105,10 +105,16 @@ public Component(Component component)
 			owner = component.Owner;
 		}
 
+		// Since v5.6
+		[Obsolete("This method is not used and will be removed in a future version")]
 		public override void SetTypeUsingReflection(string className, string propertyName, string accesorName)
 		{
 		}
 
+		public override void SetTypeUsingReflection(System.Type propertyOwnerType, string propertyName, string accesorName)
+		{
+		}
+
 		/// <summary></summary>
 		public bool IsEmbedded
 		{

src/NHibernate/Mapping/IValue.cs

@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using NHibernate.Engine;
 using NHibernate.Type;
@@ -78,6 +79,8 @@ public interface IValue
 
 		FetchMode FetchMode { get; }
 
+		// Since v5.6
+		[Obsolete("This method is not used and will be removed in a future version")]
 		void SetTypeUsingReflection(string className, string propertyName, string accesorName);
 
 		object Accept(IValueVisitor visitor);

src/NHibernate/Mapping/OneToMany.cs

@@ -125,6 +125,8 @@ public bool IsAlternateUniqueKey
 			get { return false; }
 		}
 
+		// Since v5.6
+		[Obsolete("This method is not used and will be removed in a future version")]
 		public void SetTypeUsingReflection(string className, string propertyName, string accesorName)
 		{
 		}

src/NHibernate/Mapping/SimpleValue.cs

@@ -341,6 +341,8 @@ public bool IsAlternateUniqueKey
 			set { isAlternateUniqueKey = value; }
 		}
 
+		// Since v5.6
+		[Obsolete("This method is not used and will be removed in a future version")]
 		public virtual void SetTypeUsingReflection(string className, string propertyName, string accesorName)
 		{
 			if (typeName == null)
@@ -359,6 +361,25 @@ public virtual void SetTypeUsingReflection(string className, string propertyName
 				}
 			}
 		}
+		
+		public virtual void SetTypeUsingReflection(System.Type propertyOwnerType, string propertyName, string accessorName)
+		{
+			if (typeName == null)
+			{
+				if (propertyOwnerType == null)
+				{
+					throw new MappingException("you must specify types for a dynamic entity: " + propertyName);
+				}
+				try
+				{
+					typeName = ReflectHelper.ReflectedPropertyClass(propertyOwnerType, propertyName, accessorName).AssemblyQualifiedName;
+				}
+				catch (HibernateException he)
+				{
+					throw new MappingException("Problem trying to set property type by reflection", he);
+				}
+			}
+		}
 
 		public virtual object Accept(IValueVisitor visitor)
 		{

src/NHibernate/Mapping/ToOne.cs

@@ -54,6 +54,8 @@ public bool IsLazy
 		/// </summary>
 		public abstract override void CreateForeignKey();
 
+		// Since v5.6
+		[Obsolete("This method is not used and will be removed in a future version")]
 		public override void SetTypeUsingReflection(string className, string propertyName, string accesorName)
 		{
 			if (referencedEntityName == null)
@@ -63,6 +65,15 @@ public override void SetTypeUsingReflection(string className, string propertyNam
 			}
 		}
 
+		public override void SetTypeUsingReflection(System.Type propertyOwnerType, string propertyName, string accessorName)
+		{
+			if (referencedEntityName == null)
+			{
+				System.Type refType = ReflectHelper.ReflectedPropertyClass(propertyOwnerType, propertyName, accessorName);
+				referencedEntityName = refType.FullName;
+			}
+		}
+
 		public override bool IsValid(Engine.IMapping mapping)
 		{
 			if (referencedEntityName == null)