Mark generated GetObjectData of generated proxy as [SecurityCritical]

Author: hazzik

src/NHibernate/Proxy/NHibernateProxyBuilder.cs

@@ -4,6 +4,7 @@
 using System.Reflection;
 using System.Reflection.Emit;
 using System.Runtime.Serialization;
+using System.Security;
 using NHibernate.Proxy.DynamicProxy;
 using NHibernate.Type;
 using NHibernate.Util;
@@ -29,11 +30,13 @@ class NHibernateProxyBuilder
 		static readonly MethodInfo LazyInitializerGetImplementationMethod = LazyInitializerType.GetMethod(nameof(ILazyInitializer.GetImplementation), System.Type.EmptyTypes);
 		static readonly IProxyAssemblyBuilder ProxyAssemblyBuilder = new DefaultProxyAssemblyBuilder();
 
+		static readonly ConstructorInfo SecurityCriticalAttributeConstructor = typeof(SecurityCriticalAttribute).GetConstructor(System.Type.EmptyTypes);
+		static readonly MethodInfo SerializableGetObjectDataMethod = typeof(ISerializable).GetMethod(nameof(ISerializable.GetObjectData));
+
 		readonly MethodInfo _getIdentifierMethod;
 		readonly MethodInfo _setIdentifierMethod;
 		readonly IAbstractComponentType _componentIdType;
 		readonly bool _overridesEquals;
-
 		public NHibernateProxyBuilder(MethodInfo getIdentifierMethod, MethodInfo setIdentifierMethod, IAbstractComponentType componentIdType, bool overridesEquals)
 		{
 			_getIdentifierMethod = getIdentifierMethod;
@@ -148,8 +151,8 @@ static void ImplementGetObjectData(TypeBuilder typeBuilder, FieldInfo proxyFacto
 			                                    MethodAttributes.Virtual;
 			var parameterTypes = new[] {typeof (SerializationInfo), typeof (StreamingContext)};
 
-			var methodBuilder =
-				typeBuilder.DefineMethod("GetObjectData", attributes, typeof (void), parameterTypes);
+			var methodBuilder = typeBuilder.DefineMethod("GetObjectData", attributes, typeof (void), parameterTypes);
+			methodBuilder.SetCustomAttribute(new CustomAttributeBuilder(SecurityCriticalAttributeConstructor, Array.Empty<object>()));
 
 			var IL = methodBuilder.GetILGenerator();
 			//LocalBuilder proxyBaseType = IL.DeclareLocal(typeof(Type));
@@ -179,9 +182,11 @@ static void ImplementGetObjectData(TypeBuilder typeBuilder, FieldInfo proxyFacto
 			IL.Emit(OpCodes.Ldarg_1);
 			IL.Emit(OpCodes.Ldarg_2);
 
-			IL.Emit(OpCodes.Callvirt, typeof(ISerializable).GetMethod(nameof(ISerializable.GetObjectData)));
+			IL.Emit(OpCodes.Callvirt, SerializableGetObjectDataMethod);
 
 			IL.Emit(OpCodes.Ret);
+
+			typeBuilder.DefineMethodOverride(methodBuilder, SerializableGetObjectDataMethod);
 		}
 
 		public void CreateProxiedMethod(FieldInfo lazyInitializerField, MethodInfo method, TypeBuilder typeBuilder)