Fix test and review suggestions

Author: bahusoid

src/NHibernate.Test/Async/NHSpecificTest/GH3169/FixtureByCode.cs

@@ -20,17 +20,51 @@ namespace NHibernate.Test.NHSpecificTest.GH3169
 	[TestFixture]
 	public class ByCodeFixtureAsync : TestCaseMappingByCode
 	{
-		public class ResultDto
+		class ResultDto
 		{
 			public string regionCode { get; set; }
 		}
 
+		class Entity
+		{
+			public virtual int Id { get; set; }
+			public virtual string Name { get; set; }
+		}
+
 		protected override HbmMapping GetMappings()
 		{
 			var mapper = new ModelMapper();
+			mapper.Class<Entity>(rc =>
+			{
+				rc.Table("Entity");
+				rc.Id(x => x.Id, m => m.Generator(Generators.Native));
+				rc.Property(x => x.Name);
+			});
+
 			return mapper.CompileMappingForAllExplicitlyAddedEntities();
 		}
 
+		protected override void OnSetUp()
+		{
+			using (var session = OpenSession())
+			using (var transaction = session.BeginTransaction())
+			{
+				var e1 = new Entity { Name = "Bob" };
+				session.Save(e1);
+
+				transaction.Commit();
+			}
+		}
+
+		protected override void OnTearDown()
+		{
+			using (var session = OpenSession())
+			using (var transaction = session.BeginTransaction())
+			{
+				session.CreateQuery("delete from System.Object").ExecuteUpdate();
+				transaction.Commit();
+			}
+		}
 
 		[Test]
 		public async Task CachedQueryWithTransformerAsync()
@@ -40,7 +74,7 @@ Task<IList<ResultDto>> GetCacheableSqlQueryResultsAsync(ISession s)
 				try
 				{
 					return s.CreateSQLQuery(
-								"select 'REGIONCODE' as regionCode  ")
+								"select Name as regionCode from Entity")
 							.AddScalar("regionCode", NHibernateUtil.String)
 							.SetResultTransformer(Transformers.AliasToBean<ResultDto>())
 							.SetCacheable(true)
@@ -58,7 +92,7 @@ Task<IList<ResultDto>> GetCacheableSqlQueryResultsAsync(ISession s)
 				{
 					var l = await (GetCacheableSqlQueryResultsAsync(session));
 					Assert.AreEqual(1, l.Count);
-					//Uncomment if we properly fix caching auto discovery type queries with transformers
+					//TODO: Uncomment if we properly fix caching auto discovery type queries with transformers
 					//Assert.That(Sfi.Statistics.QueryCacheMissCount, Is.EqualTo(1), "results are expected from DB");
 					//Assert.That(Sfi.Statistics.QueryCacheHitCount, Is.EqualTo(0), "results are expected from DB");
 				}
@@ -67,7 +101,7 @@ Task<IList<ResultDto>> GetCacheableSqlQueryResultsAsync(ISession s)
 				{
 					var l2 = await (GetCacheableSqlQueryResultsAsync(session));
 					Assert.AreEqual(1, l2.Count);
-					//Uncomment if we properly fix caching auto discovery type queries with transformers
+					//TODO: Uncomment if we properly fix caching auto discovery type queries with transformers
 					//Assert.That(Sfi.Statistics.QueryCacheMissCount, Is.EqualTo(0), "results are expected from cache");
 					//Assert.That(Sfi.Statistics.QueryCacheHitCount, Is.EqualTo(1), "results are expected from cache");
 				}

src/NHibernate.Test/NHSpecificTest/GH3169/FixtureByCode.cs

@@ -9,25 +9,59 @@ namespace NHibernate.Test.NHSpecificTest.GH3169
 	[TestFixture]
 	public class ByCodeFixture : TestCaseMappingByCode
 	{
-		public class ResultDto
+		class ResultDto
 		{
 			public string regionCode { get; set; }
 		}
 
+		class Entity
+		{
+			public virtual int Id { get; set; }
+			public virtual string Name { get; set; }
+		}
+
 		protected override HbmMapping GetMappings()
 		{
 			var mapper = new ModelMapper();
+			mapper.Class<Entity>(rc =>
+			{
+				rc.Table("Entity");
+				rc.Id(x => x.Id, m => m.Generator(Generators.Native));
+				rc.Property(x => x.Name);
+			});
+
 			return mapper.CompileMappingForAllExplicitlyAddedEntities();
 		}
 
+		protected override void OnSetUp()
+		{
+			using (var session = OpenSession())
+			using (var transaction = session.BeginTransaction())
+			{
+				var e1 = new Entity { Name = "Bob" };
+				session.Save(e1);
+
+				transaction.Commit();
+			}
+		}
+
+		protected override void OnTearDown()
+		{
+			using (var session = OpenSession())
+			using (var transaction = session.BeginTransaction())
+			{
+				session.CreateQuery("delete from System.Object").ExecuteUpdate();
+				transaction.Commit();
+			}
+		}
 
 		[Test]
 		public void CachedQueryWithTransformer()
 		{
 			IList<ResultDto> GetCacheableSqlQueryResults(ISession s)
 			{
 				return s.CreateSQLQuery(
-							"select 'REGIONCODE' as regionCode  ")
+							"select Name as regionCode from Entity")
 						.AddScalar("regionCode", NHibernateUtil.String)
 						.SetResultTransformer(Transformers.AliasToBean<ResultDto>())
 						.SetCacheable(true)
@@ -40,7 +74,7 @@ IList<ResultDto> GetCacheableSqlQueryResults(ISession s)
 				{
 					var l = GetCacheableSqlQueryResults(session);
 					Assert.AreEqual(1, l.Count);
-					//Uncomment if we properly fix caching auto discovery type queries with transformers
+					//TODO: Uncomment if we properly fix caching auto discovery type queries with transformers
 					//Assert.That(Sfi.Statistics.QueryCacheMissCount, Is.EqualTo(1), "results are expected from DB");
 					//Assert.That(Sfi.Statistics.QueryCacheHitCount, Is.EqualTo(0), "results are expected from DB");
 				}
@@ -49,7 +83,7 @@ IList<ResultDto> GetCacheableSqlQueryResults(ISession s)
 				{
 					var l2 = GetCacheableSqlQueryResults(session);
 					Assert.AreEqual(1, l2.Count);
-					//Uncomment if we properly fix caching auto discovery type queries with transformers
+					//TODO: Uncomment if we properly fix caching auto discovery type queries with transformers
 					//Assert.That(Sfi.Statistics.QueryCacheMissCount, Is.EqualTo(0), "results are expected from cache");
 					//Assert.That(Sfi.Statistics.QueryCacheHitCount, Is.EqualTo(1), "results are expected from cache");
 				}