OnPreUpdateCollection - Passed entity instance X is not of expected type Y

[marjohansson]

Hi!

When updating from version 5.2.7 to 5.3.2, we get the following error in OnPreUpdateCollection event listener.

Seems to occur when changing a collection in a class (joined subclass) with a lazy property .

Using the lazy property gives us the ProxyForFieldInterceptor and the exception.

at NHibernate.Tuple.Entity.BytecodeEnhancementMetadataPocoImpl.ExtractInterceptor(Object entity)
at NHibernate.Tuple.Entity.BytecodeEnhancementMetadataPocoImpl.HasAnyUninitializedLazyProperties(Object entity)
at NHibernate.Tuple.Entity.AbstractEntityTuplizer.ShouldGetAllProperties(Object entity)
at NHibernate.Tuple.Entity.PocoEntityTuplizer.GetPropertyValues(Object entity)
at NHibernate.Persister.Entity.AbstractEntityPersister.GetPropertyValues(Object obj)
at NHibernate.Test.NHSpecificTest.GH2508.AuditEventListener.OnPreUpdateCollection(PreCollectionUpdateEvent event) in

Thank you for keeping NH alive!

[bahusoid]

Can you share a test case(Exception stack trace hints that you already have one)?

@maca88 Looks like regression after #1946
Shouldn't the check below should use IsAssignableFrom instead of equality?:

nhibernate-core/src/NHibernate/Tuple/Entity/BytecodeEnhancementMetadataPocoImpl.cs

Lines 173 to 177 in 9fc784e

	if (_entityType != interceptor.MappedClass)
	{
	throw new ArgumentException(
	$"Passed entity instance [{entity}] is not of expected type [{EntityName}]");
	}

[marjohansson]

AuditEventListener.zip
The event listener is created in the TestConfigurationHelper class in the test project.

[maca88]

Looks like regression after #1946

Correct.

Shouldn't the check below should use IsAssignableFrom instead of equality?:

Yes we should, Hibernate uses isInstance, which is equivalent to IsAssignableFrom in .NET.

@marjohansson thanks for the test case.