@mickfold could you please update documentation to reflect these changes?

@hazzik I don't know how to do update the documentation on nhforge. Is there a guide on how to do this?

@mcharalambous The reference documenation is in DocBook XML in the doc directory of the code repository. Publishing to nhforge will happen later.

@oskarb thanks.

@hazzik and @oskarb I've made a (minor) update to the docs to reflect the changes to the cascade options. Would you like for me to expand on this? I could add to the section on one-to-one putting some further information about the variations of one-to-one mapping that NHibernate supports.

I'm currently wishing this issue was fixed. However, it looks like this pull request does more than adding all-delete-orphan to one-to-one. It also introduces a new cascade, delete-orphan, to NHibernate. Is this from porting the Hibernate code?

@dschilling Yes, everything that was added was done so because it was part of the Hibernate feature HHH-4726. When porting the feature I tried to stick as closely to the original hibernate code as possible with the aim of getting the ported unit tests to pass.

@mickfold could you please rebase your PR on top of master branch? Thanks.

@mickfold ?

@hazzik Sorry for the delay. I have rebased my PR on to the top of the master branch. Please let me know if it looks okay. Thanks.

@hazzik I've fixed the formatting issue you highlighted. Please let me know if you find anything else which needs to be fixed. Thanks.

There is probably one big things need to be done: make this work with MappingByCode as well, if it is not supported yet.

Have all these commits been ported?

hibernate/hibernate-orm@b150dc7
hibernate/hibernate-orm@56f6941
hibernate/hibernate-orm@29152a8
hibernate/hibernate-orm@f163e9f
hibernate/hibernate-orm@6cfc0c0
hibernate/hibernate-orm@55cd2ee
hibernate/hibernate-orm@2f3a967

Can you please make sure that code follows C# code conventions? Methods and properties with capital letter. Thanks

@hazzik Yes, those are the commits I ported but due to some implementation differences, such as classes like HbmBinder existing in Hibernate but not NHibernate, the port is not a line for line copy. I did try to make the test cases as close to the original Java code as close as possible though.

I've also updated all the tests code so methods and properties have capital letters and have started to work on MappingByCode.

@mickfold Any news on MappingByCode support?

@hazzik I'm down to one failing test case which is the Bidirectional Foreign Key Composite Id test. From looking at the XML code generated by the MappingByCode its missing out some properties which is causing problems, i.e.

mc.ManyToOne<EmployeeInfo>(x => x.Info, m =>
{
  m.Unique(true);
  m.NotFound(NotFoundMode.Exception);
  m.Cascade(Mapping.ByCode.Cascade.All | Mapping.ByCode.Cascade.DeleteOrphans);
  m.Columns(x => { x.Name("COMP_ID"); }, x => { x.Name("PERS_ID"); });
});

when exported to XML becomes:

<many-to-one name="Info" cascade="all,delete-orphan">
  <column name="COMP_ID" />
  <column name="PERS_ID" />
</many-to-one>

but should be

<many-to-one name="Info" unique="true" cascade="all,delete-orphan"  not-found="exception">
  <column name="COMP_ID" />
  <column name="PERS_ID" />
</many-to-one>

I'm investigating why this is happening at the moment.

@hazzik one-to-one cascade delete orphan is now supported in MappingByCode.

Btw there are now 3 tests that are now failing which are checking for unsupported cascade styles. These are now redundant, should I delete them? I've listed the tests below.

AnyMapperTest.AutoCleanInvalidCascade
ManyToOneMapperTest.AutoCleanUnsupportedCascadeStyle
OneToOneMapperTest.AutoCleanUnsupportedCascadeStyle

Finally, one strange thing I discovered is that if you specify columns in the mapper it resets a lot of other fields to the default values, which mean I had to change the order of the mapping to the following to get it to work.

mc.ManyToOne(x => x.Info, m =>
{
m.Columns(x => { x.Name("COMP_ID"); }, x => { x.Name("PERS_ID"); });
m.Unique(true);
m.NotFound(NotFoundMode.Exception);
m.Cascade(Mapping.ByCode.Cascade.All | Mapping.ByCode.Cascade.DeleteOrphans);
});

Yes, please delete these tests

@hazzik I've removed the redundant test. Should I squash the 5 commits into a single commit?

Great work, @mickfold! Thanks!

LGTM!

In general I prefer to reserve the NHSpecificTest//NHxxxx convention for specific bug tests or corner cases. For basic functionality it would be better to organize the tests by functional area. Isn't there any existing test case folders for cascade etc., where these test cases or fixtures should be added?

@oskarb There's a cascade folder off the root test project. The tests could be moved there. What do you think?

Ok @mickfold can you please implement changes requested by @oskarb and rebase the PR on top of master branch?

@hazzik @oskarb just to clarify. Should I move the tests to the Cascade folder?

@mickfold sure

@hazzik @oskarb The tests have been moved and the PR has been rebased on top of the master branch.

Thanks a lot @mickfold!

Merged, thanks