Add logging for QueryBatch similar to Loader.DoQuery #2304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahusoid
commented
Jan 13, 2020
| @@ -16,6 +16,8 @@ namespace NHibernate.Multi | |||
| /// </summary> | |||
| public abstract partial class QueryBatchItemBase<TResult> : IQueryBatchItem<TResult>, IQueryBatchItemWithAsyncProcessResults | |||
| { | |||
| private static readonly INHibernateLogger Log = NHibernateLogger.For(typeof(QueryBatch)); | |||
There was a problem hiding this comment.
QueryBatch type here is intentional.. Don't want to create separate logger for each result type
fredericDelaporte
approved these changes
Jan 13, 2020
fredericDelaporte
force-pushed
the
gh2296
branch
from
75a8c45 to
ddbfba9
Compare
|
Rebased (and squashed) to have the Travis fix commit in this PR branch. |
hazzik
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2296
Added logging from
Loader.DoQueryto QueryBatchWe might also fix this one in 5.2.
It's not exactly a regression as debug logging is not a public API. And this logging is not present for criteria
MultiCriteriaImplbut only inMultiQueryImpl.But I agree logging for
List()and forFuture().List()should be the same if possible.And this logging is missing for hql Future queries in 5.2 - so might be considered as regression.
What do you think?