Skip to content

Fix detecting parameter types in subqueries for Linq provider #2443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2020
Merged

Fix detecting parameter types in subqueries for Linq provider #2443

merged 2 commits into from
Jul 22, 2020

Conversation

maca88
Copy link
Contributor

@maca88 maca88 commented Jul 21, 2020

Fix a regression from #2036, where subqueries were not traversed when detecting expression types.

Fixes #2439

@fredericDelaporte fredericDelaporte self-requested a review July 21, 2020 17:29
@fredericDelaporte fredericDelaporte dismissed their stale review July 21, 2020 17:31

Failing tests

@fredericDelaporte fredericDelaporte removed their request for review July 21, 2020 17:31
@fredericDelaporte fredericDelaporte added this to the 5.3.1 milestone Jul 21, 2020
@hazzik hazzik changed the base branch from master to 5.3.x July 22, 2020 02:01
@hazzik hazzik merged commit cf1cc9c into nhibernate:5.3.x Jul 22, 2020
@hazzik hazzik mentioned this pull request Jul 22, 2020
Closed
@maca88 maca88 mentioned this pull request Jul 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hazzik hazzik hazzik approved these changes

@fredericDelaporte fredericDelaporte fredericDelaporte left review comments

Assignees
No one assigned
Labels
r: Fixed t: Fix
Projects
None yet
Milestone
5.3.1
Development

Successfully merging this pull request may close these issues.

Invalid parameter conversion for enums
3 participants
@maca88 @hazzik @fredericDelaporte