Add Check(string) to IClassAttributesMapper<TEntity> #3684
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazzik
requested changes
Aug 22, 2025
| void Discriminator(Action<IDiscriminatorMapper> discriminatorMapping); | ||
| void DiscriminatorValue(object value); | ||
| void Table(string tableName); | ||
| void Check(string check); |
There was a problem hiding this comment.
This technically changes the interface and would be a binary breaking change. Could you please instead create an extension method for it? Also, please add some tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In NHibernate.Mapping.ByCode, the class Check() method is implemented but not exposed for use.
Sample code:
This commit adds the Check() method to correct interface for above sample to work.