Skip to content

Add Sql2008ClientDriver TeamCity configuration #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2017

Conversation

hazzik
Copy link
Member

@hazzik hazzik commented Sep 21, 2017

No description provided.

@hazzik hazzik merged commit 2fe11e9 into nhibernate:master Sep 21, 2017
@fredericDelaporte
Copy link
Member

Shouldn't we instead switch all SqlClientDriver to Sql2008ClientDriver? Having the old one prevents testing NH-1752, and what sens does it makes to test Sql2008+ with the old driver instead of its corresponding one?

@hazzik hazzik deleted the teamcity-Sql2008ClientDriver branch September 21, 2017 21:02
@hazzik
Copy link
Member Author

hazzik commented Sep 21, 2017

I'm, actually, considering make Sql2008ClientDriver the default one (rename it to SqlClientDriver), and the old one rename as LegacySqlClientDriver

@fredericDelaporte
Copy link
Member

#698 has switched all remaining SqlClientDriver configured usages in TeamCity to Sql2008ClientDriver. So the dedicated configuration for Sql2008ClientDriver should be removed now in my opinion, and its teamcity build too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants