Skip to content

Commit c74f7ac

Browse files
committed
Using MappingTools.RelationCharacter where appropriate.
1 parent f1f2e0f commit c74f7ac

File tree

4 files changed

+11
-8
lines changed

4 files changed

+11
-8
lines changed

Src/NHibernate.Envers/Configuration/AuditEntitiesConfiguration.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
using System;
22
using System.Collections.Generic;
3+
using NHibernate.Envers.Tools;
34
using NHibernate.Mapping;
45

56
namespace NHibernate.Envers.Configuration
@@ -81,7 +82,7 @@ public string GetAuditEntityName(string referencingEntityName, string referenced
8182
{
8283
return string.Concat(_auditTablePrefix,
8384
referencingEntityName.Substring(referencingEntityName.LastIndexOf(".") + 1),
84-
"_",
85+
MappingTools.RelationCharacter,
8586
referencedEntityName.Substring(referencedEntityName.LastIndexOf(".") + 1),
8687
_auditTableSuffix);
8788
}

Src/NHibernate.Envers/Configuration/DefaultNamingStrategy.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
using System;
2+
using NHibernate.Envers.Tools;
23
using NHibernate.Mapping;
34

45
namespace NHibernate.Envers.Configuration
@@ -31,9 +32,9 @@ public virtual string UnidirectionOneToManyTableName(PersistentClass referencing
3132
var referencingEntityName = referencingPersistentClass.EntityName;
3233
return string.Concat(DefaultPrefix,
3334
referencingEntityName.Substring(referencingEntityName.LastIndexOf(".") + 1),
34-
"_",
35+
MappingTools.RelationCharacter,
3536
referencedEntityName.Substring(referencedEntityName.LastIndexOf(".") + 1),
36-
DefaultSuffix);
37+
DefaultSuffix);
3738
}
3839

3940
public virtual string CollectionTableName(Mapping.Collection originalCollection)

Src/NHibernate.Envers/Configuration/Metadata/CollectionMetadataGenerator.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ private void addOneToManyAttached(bool fakeOneToManyBidirectional)
127127

128128
// Generating the id mappers data for the referencing side of the relation.
129129
var referencingIdData = createMiddleIdData(referencingIdMapping,
130-
mappedBy + "_", _referencingEntityName);
130+
mappedBy + MappingTools.RelationCharacter, _referencingEntityName);
131131

132132
// And for the referenced side. The prefixed mapper won't be used (as this collection isn't persisted
133133
// in a join table, so the prefix value is arbitrary).
@@ -290,14 +290,14 @@ private void addWithMiddleTable()
290290
// If the relation is inverse, then referencedEntityName is not null.
291291
mappedBy = getMappedBy(_propertyValue.CollectionTable, _mainGenerator.Cfg.GetClassMapping(_referencedEntityName));
292292

293-
referencingPrefixRelated = mappedBy + "_";
293+
referencingPrefixRelated = mappedBy + MappingTools.RelationCharacter;
294294
referencedPrefix = StringTools.GetLastComponent(_referencedEntityName);
295295
}
296296
else
297297
{
298298
mappedBy = null;
299299

300-
referencingPrefixRelated = StringTools.GetLastComponent(_referencingEntityName) + "_";
300+
referencingPrefixRelated = StringTools.GetLastComponent(_referencingEntityName) + MappingTools.RelationCharacter;
301301
referencedPrefix = _referencedEntityName == null ? "element" : _propertyName;
302302
}
303303

@@ -415,7 +415,7 @@ private MiddleComponentData addValueToMiddleTable(IValue value, XElement xmlMapp
415415
var type = value.Type;
416416
if (type is ManyToOneType)
417417
{
418-
var prefixRelated = prefix + "_";
418+
var prefixRelated = prefix + MappingTools.RelationCharacter;
419419
var referencedEntityName = MappingTools.ReferencedEntityName(value);
420420

421421
var referencedIdMapping = _mainGenerator.GetReferencedIdMappingData(_referencingEntityName,

Src/NHibernate.Envers/Query/Criteria/CriteriaTools.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
using NHibernate.Envers.Exceptions;
44
using NHibernate.Envers.Query.Property;
55
using NHibernate.Envers.Reader;
6+
using NHibernate.Envers.Tools;
67

78
namespace NHibernate.Envers.Query.Criteria
89
{
@@ -58,7 +59,7 @@ public static string DeterminePropertyName(AuditConfiguration auditCfg, IAuditRe
5859
{
5960
return auditCfg.AuditEntCfg.OriginalIdPropName + "." + propertyName;
6061
}
61-
if (propertyName.StartsWith(idPropertyName + "_"))
62+
if (propertyName.StartsWith(idPropertyName + MappingTools.RelationCharacter))
6263
{
6364
return auditCfg.AuditEntCfg.OriginalIdPropName + "." + propertyName.Substring(idPropertyName.Length + 1);
6465
}

0 commit comments

Comments
 (0)