Another pass on long press

Added ability to configure the milliseconds. Unfortunately the Windows operating system provides keyboard events based on the Windows Keyboard control panel configuration. Precision appears to be 250ms at the minimum.

Author: nhmkdev

Format/InputConfig.cs

@@ -22,6 +22,7 @@
 // SOFTWARE.
 ////////////////////////////////////////////////////////////////////////////////
 
+using Support.UI;
 using System.IO;
 using System.Windows.Forms;
 
@@ -70,7 +71,7 @@ public override string GetDescription()
                    (IsFlaggedAs(InputFlag.Shift) ? "+Shift" : string.Empty) +
                    (IsFlaggedAs(InputFlag.Alt) ? "+Alt" : string.Empty) +
                    (IsFlaggedAs(InputFlag.Control) ? "+Control" : string.Empty) +
-                   (IsFlaggedAs(InputFlag.LongPress) ? "+LongPress" : string.Empty) +
+                   (IsFlaggedAs(InputFlag.LongPress) ? "+LongPress[{0}ms]".FormatString(Parameter.ToString()) : string.Empty) +
                    "]";
         }
     }

Forms/KeyCaptureConfig.cs

@@ -653,6 +653,12 @@ private InputConfig UpdateInputFlags(InputConfig zInputConfig)
             nFlags = BitUtil.UpdateFlag(nFlags, bShift, InputConfig.InputFlag.Shift);
             nFlags = BitUtil.UpdateFlag(nFlags, bLongPress, InputConfig.InputFlag.LongPress);
             zInputConfig.Flags = nFlags;
+
+            if (bLongPress)
+            {
+                zInputConfig.Parameter = (int)numericUpDownInputParameter.Value;
+            }
+
             return zInputConfig;
         }
 
@@ -713,7 +719,7 @@ private void ConfigureToolTips()
         {
             var zToolTip = new ToolTip()
             {
-                AutoPopDelay = 5000,
+                AutoPopDelay = 10000,
                 InitialDelay = 500,
                 ReshowDelay = 250,
                 ShowAlways = false,
@@ -722,6 +728,8 @@ private void ConfigureToolTips()
             zToolTip.SetToolTip(checkInputAlt, "Requires Alt to be pressed");
             zToolTip.SetToolTip(checkInputControl, "Requires Ctrl to be pressed");
             zToolTip.SetToolTip(checkInputShift, "Requires Shift to be pressed");
+            zToolTip.SetToolTip(checkInputLongPress, "Require the key to be held for a minimum amount of time");
+            zToolTip.SetToolTip(numericUpDownInputParameter, "The minimum duration of the long press (milliseconds). \n\nNOTE: The 'Repeat Delay' setting in the Windows Keyboard control panel has a direct impact on how low this can be.");
 
             zToolTip.SetToolTip(checkOutputAlt, "Generates Alt event");
             zToolTip.SetToolTip(checkOutputControl, "Generates Ctrl event");

Forms/KeyCaptureConfig.designer.cs

@@ -24,6 +24,10 @@
 
 extern RemapEntryContainerListItem* g_KeyTranslationTable[WIN_KEY_COUNT];
 
+const int LONG_PRESS_MIN = 100;
+const int KEY_DOWN_UNSET = 0; // key not being held
+const int KEY_DOWN_EVENT_FIRED = 1; // key is held and already sent output
+// other values stored in g_KeyDownTime are the original key down time as returned by GetTickCount64
 ULONGLONG g_KeyDownTime[WIN_KEY_COUNT];
 
 /*
@@ -83,13 +87,49 @@ LRESULT CALLBACK LowLevelKeyboardProc(int nCode, WPARAM wParam, LPARAM lParam)
 						&& !bShift
 						&& pKeyDef->inputFlag.bLongPress)
 					{
-						if (g_KeyDownTime[pKeyDef->virtualKey] == 0) // ignore all keydown events on this key after recording the initial key down time
+						switch(g_KeyDownTime[pKeyDef->virtualKey])
+						{
+						case KEY_DOWN_UNSET:
 						{
 							const ULONGLONG tickCount = GetTickCount64();
 							g_KeyDownTime[pKeyDef->virtualKey] = tickCount;
 #ifdef _DEBUG
 							LogDebugMessage("Detected LONGPRESS Key Down: %d Tick: %d", pKeyDef->virtualKey, tickCount);
 #endif
+						}
+							break;
+
+						case KEY_DOWN_EVENT_FIRED:
+							// nothing for now
+							break;
+						default:
+						{
+							const ULONGLONG tickCount = GetTickCount64();
+							const unsigned int longPressMinimum = max(LONG_PRESS_MIN, pKeyDef->parameter);
+#if false
+							// windows has a built repeat rate limiter so the shortest time is 250ms
+							const ULONGLONG diff = tickCount - g_KeyDownTime[pKeyDef->virtualKey];
+							LogDebugMessage("diff: %d", diff);
+#endif
+							if (tickCount - g_KeyDownTime[pKeyDef->virtualKey] >= longPressMinimum)
+							{
+#ifdef _DEBUG
+								char* pInputConfigDescription = GetInputConfigDescription(*pKeyDef);
+								LogDebugMessage("Detected LONGPRESS [Key Down: %s] [Outputs: %d][longPressMinimum: %d]", 
+									pInputConfigDescription, 
+									pKeyListItem->pEntryContainer->pEntry->outputCount, 
+									longPressMinimum);
+								free(pInputConfigDescription);
+#endif
+								// If there is NOT an existing thread OR the existing thread is running a repeat another key press is allowed
+								if (NULL == pKeyListItem->pEntryContainer->pEntryState->threadHandle || pKeyListItem->pEntryContainer->pEntryState->bRepeating)
+								{
+									pKeyListItem->pEntryContainer->pEntryState->threadHandle = CreateThread(NULL, 0, SendInputThread, pKeyListItem->pEntryContainer, 0, NULL);
+								}
+								g_KeyDownTime[pKeyDef->virtualKey] = KEY_DOWN_EVENT_FIRED;
+							}
+						}
+							break;
 						}
 						// block further processing with the inputs
 						bSentInput = true;
@@ -121,27 +161,14 @@ LRESULT CALLBACK LowLevelKeyboardProc(int nCode, WPARAM wParam, LPARAM lParam)
 						&& !bShift
 						&& pKeyDef->inputFlag.bLongPress)
 					{
-						ULONGLONG tickCount = GetTickCount64();
-						if (tickCount - g_KeyDownTime[pKeyDef->virtualKey] > 1000)
-						{
-#ifdef _DEBUG
-							char* pInputConfigDescription = GetInputConfigDescription(*pKeyDef);
-							LogDebugMessage("Detected LONGPRESS Key Up: %s Outputs: %d", pInputConfigDescription, pKeyListItem->pEntryContainer->pEntry->outputCount);
-							free(pInputConfigDescription);
-#endif
-							// If there is NOT an existing thread OR the existing thread is running a repeat another key press is allowed
-							if (NULL == pKeyListItem->pEntryContainer->pEntryState->threadHandle || pKeyListItem->pEntryContainer->pEntryState->bRepeating)
-							{
-								pKeyListItem->pEntryContainer->pEntryState->threadHandle = CreateThread(NULL, 0, SendInputThread, pKeyListItem->pEntryContainer, 0, NULL);
-							}
-						}
-						else
+						if (g_KeyDownTime[pKeyDef->virtualKey] != KEY_DOWN_EVENT_FIRED)
 						{
+							const ULONGLONG tickCount = GetTickCount64();
 							LogDebugMessage("Detected LONGPRESS Key UP (too short): %d Tick: %d (Old Tick: %d)", pKeyDef->virtualKey, tickCount, g_KeyDownTime[pKeyDef->virtualKey]);
 							// when a longpress "fails" just send the normal keypress
 							CreateThread(NULL, 0, SendInputKeypress, pKeyDef, 0, NULL);
 						}
-						g_KeyDownTime[pKeyDef->virtualKey] = 0;
+						g_KeyDownTime[pKeyDef->virtualKey] = KEY_DOWN_UNSET;
 						// block further processing with the inputs
 						bSentInput = true;
 						break;

KeyCapLib/keyboardproc.cpp

@@ -55,5 +55,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("2.0.0.5")]
-[assembly: AssemblyFileVersion("2.0.0.5")]
+[assembly: AssemblyVersion("2.1.0.0")]
+[assembly: AssemblyFileVersion("2.1.0.0")]