Axe fix + sonar fixes

Author: davethepunkyone

utils/axe.py

@@ -16,6 +16,7 @@ class Axe():
     under test to identify any accessibility concerns.
     """
 
+    @staticmethod
     def run(
         page: Page,
         filename: str = "",
@@ -56,6 +57,7 @@ def run(
             json_report_generated=json_report_generated,
         )
 
+    @staticmethod
     def run_list(
         page: Page,
         page_list: list[str],

utils/nhs_number_tools.py

@@ -8,8 +8,6 @@ class NHSNumberTools:
     """
     A utility class providing functionality around NHS numbers.
     """
-    def __init__(self) -> None:
-        pass
 
     @staticmethod
     def _nhs_number_checks(nhs_number: str) -> None:
@@ -21,7 +19,7 @@ def _nhs_number_checks(nhs_number: str) -> None:
         """
         if not nhs_number.isnumeric():
             raise NHSNumberToolsException("The NHS number provided ({}) is not numeric.".format(nhs_number))
-        if not len(nhs_number) == 10:
+        if len(nhs_number) != 10:
             raise NHSNumberToolsException("The NHS number provided ({}) is not 10 digits.".format(nhs_number))
 
     @staticmethod

utils/user_tools.py

@@ -26,7 +26,7 @@ def retrieve_user(user: str) -> dict:
         with open(USERS_FILE, 'r') as file:
             user_data = json.loads(file.read())
 
-        if not user in user_data:
+        if user not in user_data:
             raise UserToolsException(f"User [{user}] is not present in users.json")
 
         logger.debug(f"Returning user: {user_data[user]}")