Skip to content

Commit bb6ac90

Browse files
author
Chris Mainey
committed
resolve conflict
1 parent b1294fc commit bb6ac90

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Imports: dplyr,
2323
ggrepel,
2424
ggplot2,
2525
scales
26-
RoxygenNote: 7.1.1
26+
RoxygenNote: 7.1.2
2727
Suggests:
2828
testthat (>= 3.0.0),
2929
knitr,

NEWS.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
# FunnelPlotR 0.4.2
2+
3+
Major tidy up of the UI, inputs and the control. This is was to avoid inconsistency and help
4+
5+
16
# FunnelPlotR 0.3.2
27

38
- Bug fix for limits related to NHS Digital SHMI method, correcting truncation and rounding issue that led to wrong limits being too wide.

R/funnel_plot.R

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@
110110
#' @importFrom stats na.omit
111111
#' @import ggplot2
112112

113-
114113
funnel_plot <- function(numerator, denominator, group
115114
, data_type = "SR", limit = 99, label = "outlier"
116115
, highlight = NA, draw_unadjusted = FALSE
@@ -127,7 +126,7 @@ funnel_plot <- function(numerator, denominator, group
127126

128127
# Version 0.4 deprecation warnings
129128
if (!missing(label_outliers)) {
130-
warning('The label_outliers argument deprecated; please use the label argument, e.g. label = "outlier" instead. For more options, see the help: ?funnel_plot',
129+
warning('The `label_outliers` argument deprecated; please use the `label` argument, e.g. `label = "outlier"` instead. For more options, see the help: `?funnel_plot`',
131130
call. = FALSE)
132131
if(label_outliers == TRUE){
133132
label <- "outlier"
@@ -138,7 +137,7 @@ funnel_plot <- function(numerator, denominator, group
138137

139138
# Version 0.4 deprecation warnings
140139
if (!missing(Poisson_limits)) {
141-
warning('The Poisson_limits argument deprecated; please use the draw_unadjusted argument. For more information, see the help: ?funnel_plot',
140+
warning('The `Poisson_limits` argument deprecated; please use the `draw_unadjusted` argument. For more information, see the help: `?funnel_plot`',
142141
call. = FALSE)
143142
if(Poisson_limits == TRUE){
144143
draw_unadjusted <- TRUE
@@ -149,7 +148,7 @@ funnel_plot <- function(numerator, denominator, group
149148

150149
# Version 0.4 deprecation warnings
151150
if (!missing(OD_adjust)) {
152-
warning('The OD_adjust argument deprecated; please use the draw_adjusted argument. For more information, see the help: ?funnel_plot',
151+
warning('The `OD_adjust` argument deprecated; please use the `draw_adjusted` argument. For more information, see the help: `?funnel_plot`',
153152
call. = FALSE)
154153
if(OD_adjust == TRUE){
155154
draw_adjusted <- TRUE
@@ -160,19 +159,20 @@ funnel_plot <- function(numerator, denominator, group
160159

161160
# Version 0.4 deprecation warnings
162161
if (!missing(xrange)) {
163-
warning('The xrange argument deprecated; please use the x_range argument instead. For more options, see the help: ?funnel_plot',
162+
warning('The `xrange` argument deprecated; please use the `x_range` argument instead. For more options, see the help: `?funnel_plot`',
164163
call. = FALSE)
165164
x_range <- xrange
166165
}
167166

168167
# Version 0.4 deprecation warnings
169168
if (!missing(yrange)) {
170-
warning('The yrange argument deprecated; please use the y_range argument instead. For more options, see the help: ?funnel_plot',
169+
warning('The `yrange` argument deprecated; please use the `y_range` argument instead. For more options, see the help: `?funnel_plot`',
171170
call. = FALSE)
172171
y_range <- yrange
173172
}
174173

175174

175+
176176
# build initial dataframe of obs/predicted, with error message caught here in 'try'
177177

178178
if (missing(denominator)) {

0 commit comments

Comments
 (0)